ci: fail safe on triage comment-lookup error#86
Merged
Conversation
github-actions
Bot
added
S: Untriaged
duzos
added
T: Bugfix
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the issue triage GitHub Actions workflow so that failures during the “find existing triage comment” lookup don’t accidentally trigger “first triage” behavior that could re-apply labels/fields and overwrite maintainer changes.
Changes:
- Reworks the triage-comment lookup to check
gh apiexit status instead of masking failures with|| true. - Fails safe on lookup errors by treating the run as a re-triage (comment refresh only; no label/field changes).
- Adds parsing to robustly extract the most recent matching comment id from paginated output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Copilot's review comment on #85.
The
CIDlookup used2>/dev/null || true, which conflated two cases:In the failure case
CIDwent empty and the run defaulted toFIRST_TRIAGE=true, so a flaky API call could re-apply labels/fields and clobber a maintainer's edits - exactly what the non-clobber logic is meant to prevent.Now the lookup's exit status is checked: on success it parses the marker id as before; on failure it fails safe - treats the run as a re-triage (no label/field changes) and posts a fresh comment if needed.