Repository navigation
Preserve worker poll identity across backend outages - #73
Merged
Merged
Conversation
2 of 24 tasks
rmcdaniel
marked this pull request as ready for review
September 25, 2026 21:57
This was referenced Sep 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #72 and Server #137. Worker-scoped retries now honor validated
backend_unavailableresponses without consuming the finite transport retry budget or changing the prepared request. Workflow, activity, query, and multiplexed workflow/update-validation polls retain their logical poll ID; registration and heartbeat also recover with the same request. Malformed and explicitly non-retryable backend replies fail closed. Direct Client calls remain bounded; shutdown interrupts the retry.Evidence: the baseline regression failed all three primary poll kinds after the generic retry budget. On the current head, the focused suite passed 83 tests; the full non-integration suite passed 1,450 tests (2 skipped, 31 deselected); Ruff, package-wide mypy, and public-boundary scan passed. CI is running. Keep #72 open through package publication and published-artifact verification.
Legacy standalone update-validation polling has no durable poll ID in the Server protocol and is intentionally not treated as identity-preserving; the multiplexed poll path is covered.