-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Tracker blocked count animation translations #7573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracker blocked count animation translations #7573
Conversation
Translate strings to values-es Translate strings to values-hu Translate strings to values-da Translate strings to values-bg
624a194 to
a36f05b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
|
|
||
| <!--TabSwitcher Trackers Animation--> | ||
| <string name="showTrackerCountInTabSwitcher">Mostra il numero dei sistemi di tracciamento nel Selettore schede</string> | ||
| <string name="trackerBlockedInTheLast7days" instruction="Placeholder is 1 tracker blocked"><b>%1$s sistemi di tracciamento bloccati </b> negli ultimi 7 giorni</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plural form used in singular tracker blocked translations
Low Severity
The trackerBlockedInTheLast7days string has instruction "Placeholder is 1 tracker blocked" indicating singular form, but several translations use plural grammatical forms. Italian uses "sistemi di tracciamento bloccati" (plural) instead of "sistema di tracciamento bloccato" (singular). Slovak uses "sledovačov" (genitive plural). Swedish uses "blockerade" (plural) instead of "blockerad". Lithuanian also uses plural forms. This results in grammatically incorrect text when displaying singular counts to users.
Please tell me if this was useful or not with a 👍 or 👎.
Additional Locations (2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoke with @mikescamell on MM, we will create a follow-up task to fix this. It's better to have a translation than having non at all.
mikescamell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ![]()
We know some translations are wrong for singular tracker in the tab switcher but i will take care of that so we can wrap the project up
9810d76
into
feature/aibrahim/toggle_tracker_count_animation
Translations for: #7492
Task/Issue URL: https://app.asana.com/1/137249556945/project/1212608036467427/task/1212746115452340
Description
Steps to test this PR
Feature 1
UI changes
Note
Adds localized strings for the tracker-blocked count animation and related settings across many locales, and updates EN resources accordingly.
trackerBlockedInTheLast7daysplus labels for the feature (settingsTrackersBlockedAnimationHeaderTitle,showTrackerCountInAddressBar,showWeeklyTrackerCountInTabSwitcher) invalues-*.xmlvalues/donottranslate.xmland adds them tovalues/strings.xml(EN), replacing the oldshowTrackerCountInTabSwitcherWritten by Cursor Bugbot for commit a36f05b. This will update automatically on new commits. Configure here.