Skip to content

Conversation

@aibrahim-
Copy link
Contributor

@aibrahim- aibrahim- commented Jan 23, 2026

Translations for: #7492
Task/Issue URL: https://app.asana.com/1/137249556945/project/1212608036467427/task/1212746115452340

Description

Steps to test this PR

Feature 1

  • [ ]
  • [ ]

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

Note

Adds localized strings for the tracker-blocked count animation and related settings across many locales, and updates EN resources accordingly.

  • Introduces trackerBlockedInTheLast7days plus labels for the feature (settingsTrackersBlockedAnimationHeaderTitle, showTrackerCountInAddressBar, showWeeklyTrackerCountInTabSwitcher) in values-*.xml
  • Removes these keys from values/donottranslate.xml and adds them to values/strings.xml (EN), replacing the old showTrackerCountInTabSwitcher
  • Minor copy/format adjustments per locale (bold tags, placeholders)

Written by Cursor Bugbot for commit a36f05b. This will update automatically on new commits. Configure here.

@aibrahim- aibrahim- requested a review from mikescamell January 23, 2026 13:41
Translate strings to values-es
Translate strings to values-hu
Translate strings to values-da
Translate strings to values-bg
@mikescamell mikescamell self-assigned this Jan 27, 2026
@aibrahim- aibrahim- force-pushed the feature/aibrahim/toggle_tracker_translations branch from 624a194 to a36f05b Compare January 27, 2026 11:55
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.


<!--TabSwitcher Trackers Animation-->
<string name="showTrackerCountInTabSwitcher">Mostra il numero dei sistemi di tracciamento nel Selettore schede</string>
<string name="trackerBlockedInTheLast7days" instruction="Placeholder is 1 tracker blocked">&lt;b&gt;%1$s sistemi di tracciamento bloccati &lt;/b&gt; negli ultimi 7 giorni</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plural form used in singular tracker blocked translations

Low Severity

The trackerBlockedInTheLast7days string has instruction "Placeholder is 1 tracker blocked" indicating singular form, but several translations use plural grammatical forms. Italian uses "sistemi di tracciamento bloccati" (plural) instead of "sistema di tracciamento bloccato" (singular). Slovak uses "sledovačov" (genitive plural). Swedish uses "blockerade" (plural) instead of "blockerad". Lithuanian also uses plural forms. This results in grammatically incorrect text when displaying singular counts to users.


Please tell me if this was useful or not with a 👍 or 👎.

Additional Locations (2)

Fix in Cursor Fix in Web

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke with @mikescamell on MM, we will create a follow-up task to fix this. It's better to have a translation than having non at all.

Copy link
Contributor

@mikescamell mikescamell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

We know some translations are wrong for singular tracker in the tab switcher but i will take care of that so we can wrap the project up

@aibrahim- aibrahim- merged commit 9810d76 into feature/aibrahim/toggle_tracker_count_animation Jan 27, 2026
15 checks passed
@aibrahim- aibrahim- deleted the feature/aibrahim/toggle_tracker_translations branch January 27, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants