Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Co-authored-by: oruttkay <oruttkay@duckduckgo.com>
Contributor
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: oruttkay <oruttkay@duckduckgo.com>
Contributor
|
Cursor Agent can help with this pull request. Just |
Translate strings to values-tr Translate strings to values-ru
Translate strings to values-cs
…-tab-with-translations # Conflicts: # app/src/main/java/com/duckduckgo/app/browser/omnibar/OmnibarLayout.kt # app/src/main/java/com/duckduckgo/app/browser/omnibar/OmnibarLayoutViewModel.kt # app/src/test/java/com/duckduckgo/app/browser/omnibar/OmnibarLayoutViewModelTest.kt
0nko
force-pushed
the
feature/ondrej/long-click-copy-url-custom-tab-with-translations
branch
from
cb72a5a to
bb8431e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1212330168162876?focus=true
Description
This PR implements URL copying on long-click in the custom tab.
Steps to test this PR
Note
Low Risk
Low risk UI change limited to custom tabs: adds a long-press gesture that copies the current URL and shows a toast only when the OS doesn’t provide its own clipboard notification.
Overview
Adds long-press on the custom tab address bar to copy the currently loaded URL to the clipboard.
Wires a new
CopyUrlToClipboardcommand fromOmnibarLayoutViewModeltoOmnibarLayout, which usesClipboardInteractor.copyToClipboardand conditionally shows a newurlCopiedToClipboardtoast string (localized) when the system won’t show one automatically. Includes unit tests covering non-empty vs empty URL behavior.Written by Cursor Bugbot for commit cb72a5a. This will update automatically on new commits. Configure here.