Add bit-wise operators for IP-addresses#31
Open
mpolk wants to merge 1 commit into
Open
Conversation
Add bitwise operators ("&", "|" and "~") for the IP-addresses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bit-wise operators ("&", "|" and "~") for the IP-addresses.
The ability to perform bit-wise operations on IP addresses and masks seems highly desirable for manipulating network traffic data during investigations of various network incidents. The lack of bit-wise operations and the resulting need for external scripts creates significant inconvenience, so the proposed addition seems quite useful.
The only drawback of the proposed solution appears to be the inability to meaningfully interpret binary bit-wise operations on the network mask. In this implementation, the mask of the first operand is arbitrarily copied into the result. This violates the commutativity of operations, but this sacrifice of purity for ease of manipulation does not seem particularly significant.