Make Forge labels optional - #33
Merged
Merged
Conversation
Do not interrupt running extraction or no-proposal runs for label capability; verify and apply the label only after selecting a proposal. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b8cf0691-0fe3-4d67-92ce-ce2a529c400c
There was a problem hiding this comment.
Pull request overview
Updates the Repository Skill Forge operational documentation to defer skills-forge label verification/mutation checks until after a proposal is selected, ensuring extraction/analysis can complete without being blocked by publication-only requirements.
Changes:
- Clarifies that labeled PR catalog extraction must not be blocked by pre-checking label existence/creation capability.
- Specifies that once extraction is initialized, the run must continue invoking
nextuntil the controller reaches a terminal state (deferring unrelated publication checks). - Moves label verification/creation/application requirements to the publication path only (after proposal selection), allowing successful no-proposal runs without label mutation tools.
Show a summary per file
| File | Description |
|---|---|
| plugins/repo-dreamer/skills/repository-skill-forge/SKILL.md | Refines Forge run policy to defer label and publication checks until after extraction/proposal selection. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
Use proposal markers and semantic PR search for correctness; treat the skills-forge label as best-effort organizational metadata. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b8cf0691-0fe3-4d67-92ce-ce2a529c400c
GolaraJ
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills-forgebest-effort organizational metadata that never blocks extraction, publication, or no-proposal runsWhy
Recent stateless runs completed successful session queries but reported
BLOCKEDbecause label-management tools were unavailable while extraction was stillrunning. The persistent PR marker is the authoritative Forge identity, and general PR search already detects related work, so label capability is unnecessary for correctness.Validation
git diff --check