Forge: match rendered session query results - #19
Merged
Conversation
Accept the runtime detailedContent shape that appends the rendered result after the exact controller SQL. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b8cf0691-0fe3-4d67-92ce-ce2a529c400c
There was a problem hiding this comment.
Pull request overview
This PR fixes materialize-session-query.py’s event-log matcher to accept the runtime detailedContent format where the stored payload is SQL + blank line + rendered query result, preventing valid session_store_sql completions from being rejected.
Changes:
- Update SQL matching logic to accept
detailedContentthat begins with the exact SQL followed by\n\nand additional rendered output. - Add a regression test that writes an event with
detailedContent = SQL + "\n\n" + contentand verifies the match returns the expectedcontent.
Show a summary per file
| File | Description |
|---|---|
| plugins/repo-dreamer/skills/repository-skill-forge/scripts/materialize-session-query.py | Extends detailedContent SQL matching to handle SQL-prefixed payloads that include rendered results. |
| plugins/repo-dreamer/skills/repository-skill-forge/tests/test_materialize_session_query.py | Adds a regression test covering the SQL + blank line + rendered result detailedContent shape. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detailedContentshape: exact controller SQL followed by the rendered query result3a1ceae3-1f8f-4bdb-be26-4f875e8a41b1Root cause
The bridge ran and the local event log existed, but the matcher expected
detailedContentto contain only SQL. The runtime storesSQL + blank line + rendered result, so the valid completion was rejected as not found.Validation
git diff --checkpasses