Conversation
WalkthroughThis pull request migrates from the DscConfig.Demo composite module to CommonTasks. It removes DscConfig.Demo and FileSystemDsc 1.1.0 from output/RequiredModules, updates RequiredModules.psd1 and build.yaml to reference CommonTasks, and renames configuration keys from FileSystemObjects to FilesAndFolders across multiple YAML source files. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
source/TestRsopReferences/ReferenceConfigurationTest.yml (1)
37-96:⚠️ Potential issue | 🟠 MajorAdd a regression test for the renamed resource identifiers.
This PR changes both the public key and the concrete
DependsOntargets ([FilesAndFolders]...,[File]file_*), but the checklist still says unit/integration tests were not updated. A small compile/RSOP smoke test for this reference config would catch missed legacy identifiers before release.If helpful, I can sketch the Pester coverage for this migration path.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@source/TestRsopReferences/ReferenceConfigurationTest.yml` around lines 37 - 96, Add a regression RSOP/smoke test that loads the ReferenceConfigurationTest.yml and asserts that renamed resource identifiers and concrete DependsOn targets resolve correctly: verify Resources named FilesAndFolders, WebApplicationPools, TestAppPool1 and TestAppPool2 are present and that DependsOn entries like '[FilesAndFolders]FilesAndFolders' and '[WebAppPool]TestAppPool1' (and the pool-level DependsOn on TestAppPool2) still map to the correct resources after the public key/identifier rename; implement this as a small Pester/integration test that compiles/applies the configuration and fails if any of those resource resolutions or DependsOn links are broken.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@source/Environment/Dev.yml`:
- Around line 6-9: The template renames a public Datum key to FilesAndFolders
but the consumer docs and schema/help examples weren’t updated; update all
consumer-facing documentation (README, schema definitions, help text and any
example YAML/JSON) to replace the old Datum key with FilesAndFolders, adjust
parameter descriptions and examples to match the new DestinationPath structure
and semantics, and mark the PR checklist items as completed (README/schema/help)
so users don’t see stale examples or parameter names.
---
Outside diff comments:
In `@source/TestRsopReferences/ReferenceConfigurationTest.yml`:
- Around line 37-96: Add a regression RSOP/smoke test that loads the
ReferenceConfigurationTest.yml and asserts that renamed resource identifiers and
concrete DependsOn targets resolve correctly: verify Resources named
FilesAndFolders, WebApplicationPools, TestAppPool1 and TestAppPool2 are present
and that DependsOn entries like '[FilesAndFolders]FilesAndFolders' and
'[WebAppPool]TestAppPool1' (and the pool-level DependsOn on TestAppPool2) still
map to the correct resources after the public key/identifier rename; implement
this as a small Pester/integration test that compiles/applies the configuration
and fails if any of those resource resolutions or DependsOn links are broken.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a435e65c-fa15-476c-be54-99b3b3a34206
📒 Files selected for processing (91)
.gitignoreCHANGELOG.mdRequiredModules.psd1build.yamloutput/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/ComputerSettings/ComputerSettings.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/ComputerSettings/ComputerSettings.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/ConfigurationBase/ConfigurationBase.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/ConfigurationBase/ConfigurationBase.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscDiagnostic/DscDiagnostic.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscDiagnostic/DscDiagnostic.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscLcmController/DscLcmController.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscLcmController/DscLcmController.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscLcmMaintenanceWindows/DscLcmMaintenanceWindows.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscLcmMaintenanceWindows/DscLcmMaintenanceWindows.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscTagging/DscTagging.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscTagging/DscTagging.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/EnvironmentVariables/EnvironmentVariables.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/EnvironmentVariables/EnvironmentVariables.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/FileSystemObjects/FileSystemObjects.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/FileSystemObjects/FileSystemObjects.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/FilesAndFolders/FilesAndFolders.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/FilesAndFolders/FilesAndFolders.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/LocalGroups/LocalGroups.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/LocalGroups/LocalGroups.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/LocalUsers/LocalUsers.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/LocalUsers/LocalUsers.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/NetworkIpConfiguration/NetworkIpConfiguration.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/NetworkIpConfiguration/NetworkIpConfiguration.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/RegistryValues/RegistryValues.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/RegistryValues/RegistryValues.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/Scripts/Scripts.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/Scripts/Scripts.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SecurityBase/SecurityBase.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SecurityBase/SecurityBase.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SmbShares/SmbShares.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SmbShares/SmbShares.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SoftwarePackages/SoftwarePackages.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SoftwarePackages/SoftwarePackages.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebApplicationPools/WebApplicationPools.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebApplicationPools/WebApplicationPools.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebApplications/WebApplications.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebApplications/WebApplications.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebConfigProperties/WebConfigProperties.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebConfigProperties/WebConfigProperties.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebConfigPropertyCollections/WebConfigPropertyCollections.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebConfigPropertyCollections/WebConfigPropertyCollections.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebSites/Websites.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebSites/Websites.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebVirtualDirectories/WebVirtualDirectories.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebVirtualDirectories/WebVirtualDirectories.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsEventLogs/WindowsEventLogs.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsEventLogs/WindowsEventLogs.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsFeatures/WindowsFeatures.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsFeatures/WindowsFeatures.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsOptionalFeatures/WindowsOptionalFeatures.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsOptionalFeatures/WindowsOptionalFeatures.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsServices/WindowsServices.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsServices/WindowsServices.schema.psm1output/RequiredModules/DscConfig.Demo/0.8.3/DscConfig.Demo.psd1output/RequiredModules/DscConfig.Demo/0.8.3/DscConfig.Demo.psm1output/RequiredModules/DscConfig.Demo/0.8.3/PSGetModuleInfo.xmloutput/RequiredModules/DscConfig.Demo/0.8.3/en-US/about_DscConfig.Demo.help.txtoutput/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/DSC_FileSystemAccessRule.psm1output/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/DSC_FileSystemAccessRule.schema.mofoutput/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/README.mdoutput/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/en-US/DSC_FileSystemAccessRule.strings.psd1output/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/en-US/about_FileSystemAccessRule.help.txtoutput/RequiredModules/FileSystemDsc/1.1.0/FileSystemDsc.psd1output/RequiredModules/FileSystemDsc/1.1.0/FileSystemDsc.psm1output/RequiredModules/FileSystemDsc/1.1.0/Modules/DscResource.Common/0.16.0/DscResource.Common.psd1output/RequiredModules/FileSystemDsc/1.1.0/Modules/DscResource.Common/0.16.0/DscResource.Common.psm1output/RequiredModules/FileSystemDsc/1.1.0/Modules/DscResource.Common/0.16.0/en-US/DscResource.Common.strings.psd1output/RequiredModules/FileSystemDsc/1.1.0/Modules/DscResource.Common/0.16.0/en-US/about_DscResource.Common.help.txtoutput/RequiredModules/FileSystemDsc/1.1.0/en-US/FileSystemDsc.strings.psd1output/RequiredModules/FileSystemDsc/1.1.0/en-US/about_FileSystemDsc.help.txtoutput/RequiredModules/FileSystemDsc/1.1.0/en-US/about_FileSystemObject.help.txtsource/AllNodes/Dev/DSCFile01.ymlsource/AllNodes/Dev/ReferenceConfigurationDev.ymlsource/Datum.ymlsource/Environment/Dev.ymlsource/Environment/Prod.ymlsource/Environment/Test.ymlsource/Locations/Frankfurt.ymlsource/Locations/London.ymlsource/Locations/Singapore.ymlsource/Locations/Tokio.ymlsource/Roles/FileServer.ymlsource/Roles/WebServer.ymlsource/TestRsopReferences/ReferenceConfigurationDev.ymlsource/TestRsopReferences/ReferenceConfigurationProd.ymlsource/TestRsopReferences/ReferenceConfigurationTest.yml
💤 Files with no reviewable changes (71)
- output/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/README.md
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscLcmController/DscLcmController.psd1
- output/RequiredModules/FileSystemDsc/1.1.0/Modules/DscResource.Common/0.16.0/en-US/about_DscResource.Common.help.txt
- output/RequiredModules/DscConfig.Demo/0.8.3/en-US/about_DscConfig.Demo.help.txt
- output/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/DSC_FileSystemAccessRule.schema.mof
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/RegistryValues/RegistryValues.schema.psm1
- output/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/en-US/about_FileSystemAccessRule.help.txt
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/ConfigurationBase/ConfigurationBase.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebSites/Websites.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/RegistryValues/RegistryValues.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsOptionalFeatures/WindowsOptionalFeatures.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SoftwarePackages/SoftwarePackages.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebVirtualDirectories/WebVirtualDirectories.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebConfigPropertyCollections/WebConfigPropertyCollections.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/ComputerSettings/ComputerSettings.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsServices/WindowsServices.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/LocalUsers/LocalUsers.schema.psm1
- output/RequiredModules/FileSystemDsc/1.1.0/FileSystemDsc.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/FileSystemObjects/FileSystemObjects.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscTagging/DscTagging.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SmbShares/SmbShares.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsOptionalFeatures/WindowsOptionalFeatures.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebApplications/WebApplications.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsServices/WindowsServices.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebConfigPropertyCollections/WebConfigPropertyCollections.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DscConfig.Demo.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscDiagnostic/DscDiagnostic.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/LocalGroups/LocalGroups.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/Scripts/Scripts.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscLcmMaintenanceWindows/DscLcmMaintenanceWindows.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/PSGetModuleInfo.xml
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/EnvironmentVariables/EnvironmentVariables.schema.psm1
- output/RequiredModules/FileSystemDsc/1.1.0/en-US/about_FileSystemDsc.help.txt
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsEventLogs/WindowsEventLogs.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsEventLogs/WindowsEventLogs.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsFeatures/WindowsFeatures.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/LocalGroups/LocalGroups.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/ConfigurationBase/ConfigurationBase.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/FilesAndFolders/FilesAndFolders.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebApplicationPools/WebApplicationPools.psd1
- output/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/en-US/DSC_FileSystemAccessRule.strings.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/NetworkIpConfiguration/NetworkIpConfiguration.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebConfigProperties/WebConfigProperties.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebApplicationPools/WebApplicationPools.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscLcmController/DscLcmController.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/ComputerSettings/ComputerSettings.schema.psm1
- output/RequiredModules/FileSystemDsc/1.1.0/FileSystemDsc.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DscConfig.Demo.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SecurityBase/SecurityBase.psd1
- output/RequiredModules/FileSystemDsc/1.1.0/Modules/DscResource.Common/0.16.0/en-US/DscResource.Common.strings.psd1
- output/RequiredModules/FileSystemDsc/1.1.0/en-US/FileSystemDsc.strings.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebSites/Websites.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/FileSystemObjects/FileSystemObjects.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/NetworkIpConfiguration/NetworkIpConfiguration.psd1
- output/RequiredModules/FileSystemDsc/1.1.0/en-US/about_FileSystemObject.help.txt
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebConfigProperties/WebConfigProperties.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SoftwarePackages/SoftwarePackages.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/Scripts/Scripts.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SecurityBase/SecurityBase.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebApplications/WebApplications.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscTagging/DscTagging.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsFeatures/WindowsFeatures.schema.psm1
- output/RequiredModules/FileSystemDsc/1.1.0/Modules/DscResource.Common/0.16.0/DscResource.Common.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscDiagnostic/DscDiagnostic.schema.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebVirtualDirectories/WebVirtualDirectories.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/EnvironmentVariables/EnvironmentVariables.psd1
- output/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/DSC_FileSystemAccessRule.psm1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/LocalUsers/LocalUsers.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/FilesAndFolders/FilesAndFolders.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SmbShares/SmbShares.psd1
- output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscLcmMaintenanceWindows/DscLcmMaintenanceWindows.psd1
| FilesAndFolders: | ||
| Items: | ||
| - DestinationPath: '[x= "C:\Test\$($File.BaseName)-Environment" =]' | ||
| Type: Directory |
There was a problem hiding this comment.
Update the consumer docs for the FilesAndFolders rename.
FilesAndFolders replaces a public Datum key, but the PR checklist still marks README/schema/help updates as unfinished. Merging the rename without those updates will leave users with stale examples and parameter descriptions.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@source/Environment/Dev.yml` around lines 6 - 9, The template renames a public
Datum key to FilesAndFolders but the consumer docs and schema/help examples
weren’t updated; update all consumer-facing documentation (README, schema
definitions, help text and any example YAML/JSON) to replace the old Datum key
with FilesAndFolders, adjust parameter descriptions and examples to match the
new DestinationPath structure and semantics, and mark the PR checklist items as
completed (README/schema/help) so users don’t see stale examples or parameter
names.
Pull Request
Pull Request (PR) description
Moving from DscConfig.Demo back to CommonTasks.
Task list
build.ps1 -ResolveDependency).and comment-based help.
This change is