Skip to content

Feature/common tasks#204

Merged
raandree merged 6 commits intodsccommunity:mainfrom
raandree:feature/CommonTasks
Mar 12, 2026
Merged

Feature/common tasks#204
raandree merged 6 commits intodsccommunity:mainfrom
raandree:feature/CommonTasks

Conversation

@raandree
Copy link
Contributor

@raandree raandree commented Mar 7, 2026

Pull Request

Pull Request (PR) description

Moving from DscConfig.Demo back to CommonTasks.

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@coderabbitai
Copy link

coderabbitai bot commented Mar 7, 2026

Walkthrough

This pull request migrates from the DscConfig.Demo composite module to CommonTasks. It removes DscConfig.Demo and FileSystemDsc 1.1.0 from output/RequiredModules, updates RequiredModules.psd1 and build.yaml to reference CommonTasks, and renames configuration keys from FileSystemObjects to FilesAndFolders across multiple YAML source files.

Changes

Cohort / File(s) Summary
Build Configuration
.gitignore, CHANGELOG.md, RequiredModules.psd1, build.yaml
Updated module dependencies: bumped versions for InvokeBuild, Sampler, Datum.InvokeCommand, DscResource.Test, PSDesiredStateConfiguration, and Az.* modules; added PowerShellGet 2.2.5; replaced commented DscConfig.Demo with active CommonTasks (latest); activated FileSystemDsc 1.1.1. Modified .gitignore patterns and added CHANGELOG entry documenting the migration.
DscConfig.Demo Module Removal
output/RequiredModules/DscConfig.Demo/0.8.3/.../*
Deleted entire DscConfig.Demo 0.8.3 composite module including all DSC resources: ComputerSettings, ConfigurationBase, DscDiagnostic, DscLcmController, DscLcmMaintenanceWindows, DscTagging, EnvironmentVariables, FileSystemObjects, FilesAndFolders, LocalGroups, LocalUsers, NetworkIpConfiguration, RegistryValues, Scripts, SecurityBase, SmbShares, SoftwarePackages, WebApplicationPools, WebApplications, WebConfigProperties, WebConfigPropertyCollections, WebSites, WebVirtualDirectories, WindowsEventLogs, WindowsFeatures, WindowsOptionalFeatures, WindowsServices. Also removed module manifests, PSM1 files, and help documentation.
FileSystemDsc Module Removal
output/RequiredModules/FileSystemDsc/1.1.0/.../*
Deleted FileSystemDsc 1.1.0 module including DSC_FileSystemAccessRule resource (PSM1, schema.mof), module manifest, and all localization/documentation files including nested DscResource.Common 0.16.0 dependency.
Configuration Data YAML Refactoring
source/AllNodes/Dev/*, source/Environment/*, source/Locations/*, source/Roles/*, source/TestRsopReferences/*, source/Datum.yml
Systematically renamed configuration section keys from FileSystemObjects to FilesAndFolders across development, test, and production environments; updated all DependsOn references from [FileSystemObjects]FileSystemObjects to [FilesAndFolders]FilesAndFolders; updated lookup_options in Datum.yml; adjusted resource type references in role configurations (e.g., [FileSystemObject] to [File]).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • dsccommunity/DscWorkshop#198: Both PRs modify RequiredModules.psd1 with multiple module version updates and work with the same dependency matrix.
  • dsccommunity/DscWorkshop#202: Both PRs update RequiredModules.psd1 module versions and add/modify CHANGELOG entries for version tracking.
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Feature/common tasks' is vague and uses non-descriptive terminology that doesn't clearly convey the main change; it reads more like a branch name than a meaningful commit description. Revise the title to clearly describe the main objective, such as 'Migrate from DscConfig.Demo to CommonTasks module' or 'Replace DscConfig.Demo with CommonTasks composite resource'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly states the intent to migrate from DscConfig.Demo back to CommonTasks, which directly relates to the changeset including module updates, configuration renames, and dependency changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
source/TestRsopReferences/ReferenceConfigurationTest.yml (1)

37-96: ⚠️ Potential issue | 🟠 Major

Add a regression test for the renamed resource identifiers.

This PR changes both the public key and the concrete DependsOn targets ([FilesAndFolders]..., [File]file_*), but the checklist still says unit/integration tests were not updated. A small compile/RSOP smoke test for this reference config would catch missed legacy identifiers before release.

If helpful, I can sketch the Pester coverage for this migration path.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@source/TestRsopReferences/ReferenceConfigurationTest.yml` around lines 37 -
96, Add a regression RSOP/smoke test that loads the
ReferenceConfigurationTest.yml and asserts that renamed resource identifiers and
concrete DependsOn targets resolve correctly: verify Resources named
FilesAndFolders, WebApplicationPools, TestAppPool1 and TestAppPool2 are present
and that DependsOn entries like '[FilesAndFolders]FilesAndFolders' and
'[WebAppPool]TestAppPool1' (and the pool-level DependsOn on TestAppPool2) still
map to the correct resources after the public key/identifier rename; implement
this as a small Pester/integration test that compiles/applies the configuration
and fails if any of those resource resolutions or DependsOn links are broken.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@source/Environment/Dev.yml`:
- Around line 6-9: The template renames a public Datum key to FilesAndFolders
but the consumer docs and schema/help examples weren’t updated; update all
consumer-facing documentation (README, schema definitions, help text and any
example YAML/JSON) to replace the old Datum key with FilesAndFolders, adjust
parameter descriptions and examples to match the new DestinationPath structure
and semantics, and mark the PR checklist items as completed (README/schema/help)
so users don’t see stale examples or parameter names.

---

Outside diff comments:
In `@source/TestRsopReferences/ReferenceConfigurationTest.yml`:
- Around line 37-96: Add a regression RSOP/smoke test that loads the
ReferenceConfigurationTest.yml and asserts that renamed resource identifiers and
concrete DependsOn targets resolve correctly: verify Resources named
FilesAndFolders, WebApplicationPools, TestAppPool1 and TestAppPool2 are present
and that DependsOn entries like '[FilesAndFolders]FilesAndFolders' and
'[WebAppPool]TestAppPool1' (and the pool-level DependsOn on TestAppPool2) still
map to the correct resources after the public key/identifier rename; implement
this as a small Pester/integration test that compiles/applies the configuration
and fails if any of those resource resolutions or DependsOn links are broken.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a435e65c-fa15-476c-be54-99b3b3a34206

📥 Commits

Reviewing files that changed from the base of the PR and between eacbea0 and d655e71.

📒 Files selected for processing (91)
  • .gitignore
  • CHANGELOG.md
  • RequiredModules.psd1
  • build.yaml
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/ComputerSettings/ComputerSettings.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/ComputerSettings/ComputerSettings.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/ConfigurationBase/ConfigurationBase.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/ConfigurationBase/ConfigurationBase.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscDiagnostic/DscDiagnostic.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscDiagnostic/DscDiagnostic.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscLcmController/DscLcmController.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscLcmController/DscLcmController.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscLcmMaintenanceWindows/DscLcmMaintenanceWindows.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscLcmMaintenanceWindows/DscLcmMaintenanceWindows.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscTagging/DscTagging.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscTagging/DscTagging.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/EnvironmentVariables/EnvironmentVariables.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/EnvironmentVariables/EnvironmentVariables.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/FileSystemObjects/FileSystemObjects.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/FileSystemObjects/FileSystemObjects.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/FilesAndFolders/FilesAndFolders.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/FilesAndFolders/FilesAndFolders.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/LocalGroups/LocalGroups.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/LocalGroups/LocalGroups.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/LocalUsers/LocalUsers.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/LocalUsers/LocalUsers.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/NetworkIpConfiguration/NetworkIpConfiguration.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/NetworkIpConfiguration/NetworkIpConfiguration.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/RegistryValues/RegistryValues.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/RegistryValues/RegistryValues.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/Scripts/Scripts.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/Scripts/Scripts.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SecurityBase/SecurityBase.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SecurityBase/SecurityBase.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SmbShares/SmbShares.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SmbShares/SmbShares.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SoftwarePackages/SoftwarePackages.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SoftwarePackages/SoftwarePackages.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebApplicationPools/WebApplicationPools.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebApplicationPools/WebApplicationPools.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebApplications/WebApplications.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebApplications/WebApplications.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebConfigProperties/WebConfigProperties.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebConfigProperties/WebConfigProperties.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebConfigPropertyCollections/WebConfigPropertyCollections.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebConfigPropertyCollections/WebConfigPropertyCollections.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebSites/Websites.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebSites/Websites.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebVirtualDirectories/WebVirtualDirectories.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebVirtualDirectories/WebVirtualDirectories.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsEventLogs/WindowsEventLogs.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsEventLogs/WindowsEventLogs.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsFeatures/WindowsFeatures.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsFeatures/WindowsFeatures.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsOptionalFeatures/WindowsOptionalFeatures.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsOptionalFeatures/WindowsOptionalFeatures.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsServices/WindowsServices.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsServices/WindowsServices.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DscConfig.Demo.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DscConfig.Demo.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/PSGetModuleInfo.xml
  • output/RequiredModules/DscConfig.Demo/0.8.3/en-US/about_DscConfig.Demo.help.txt
  • output/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/DSC_FileSystemAccessRule.psm1
  • output/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/DSC_FileSystemAccessRule.schema.mof
  • output/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/README.md
  • output/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/en-US/DSC_FileSystemAccessRule.strings.psd1
  • output/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/en-US/about_FileSystemAccessRule.help.txt
  • output/RequiredModules/FileSystemDsc/1.1.0/FileSystemDsc.psd1
  • output/RequiredModules/FileSystemDsc/1.1.0/FileSystemDsc.psm1
  • output/RequiredModules/FileSystemDsc/1.1.0/Modules/DscResource.Common/0.16.0/DscResource.Common.psd1
  • output/RequiredModules/FileSystemDsc/1.1.0/Modules/DscResource.Common/0.16.0/DscResource.Common.psm1
  • output/RequiredModules/FileSystemDsc/1.1.0/Modules/DscResource.Common/0.16.0/en-US/DscResource.Common.strings.psd1
  • output/RequiredModules/FileSystemDsc/1.1.0/Modules/DscResource.Common/0.16.0/en-US/about_DscResource.Common.help.txt
  • output/RequiredModules/FileSystemDsc/1.1.0/en-US/FileSystemDsc.strings.psd1
  • output/RequiredModules/FileSystemDsc/1.1.0/en-US/about_FileSystemDsc.help.txt
  • output/RequiredModules/FileSystemDsc/1.1.0/en-US/about_FileSystemObject.help.txt
  • source/AllNodes/Dev/DSCFile01.yml
  • source/AllNodes/Dev/ReferenceConfigurationDev.yml
  • source/Datum.yml
  • source/Environment/Dev.yml
  • source/Environment/Prod.yml
  • source/Environment/Test.yml
  • source/Locations/Frankfurt.yml
  • source/Locations/London.yml
  • source/Locations/Singapore.yml
  • source/Locations/Tokio.yml
  • source/Roles/FileServer.yml
  • source/Roles/WebServer.yml
  • source/TestRsopReferences/ReferenceConfigurationDev.yml
  • source/TestRsopReferences/ReferenceConfigurationProd.yml
  • source/TestRsopReferences/ReferenceConfigurationTest.yml
💤 Files with no reviewable changes (71)
  • output/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/README.md
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscLcmController/DscLcmController.psd1
  • output/RequiredModules/FileSystemDsc/1.1.0/Modules/DscResource.Common/0.16.0/en-US/about_DscResource.Common.help.txt
  • output/RequiredModules/DscConfig.Demo/0.8.3/en-US/about_DscConfig.Demo.help.txt
  • output/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/DSC_FileSystemAccessRule.schema.mof
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/RegistryValues/RegistryValues.schema.psm1
  • output/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/en-US/about_FileSystemAccessRule.help.txt
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/ConfigurationBase/ConfigurationBase.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebSites/Websites.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/RegistryValues/RegistryValues.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsOptionalFeatures/WindowsOptionalFeatures.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SoftwarePackages/SoftwarePackages.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebVirtualDirectories/WebVirtualDirectories.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebConfigPropertyCollections/WebConfigPropertyCollections.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/ComputerSettings/ComputerSettings.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsServices/WindowsServices.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/LocalUsers/LocalUsers.schema.psm1
  • output/RequiredModules/FileSystemDsc/1.1.0/FileSystemDsc.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/FileSystemObjects/FileSystemObjects.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscTagging/DscTagging.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SmbShares/SmbShares.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsOptionalFeatures/WindowsOptionalFeatures.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebApplications/WebApplications.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsServices/WindowsServices.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebConfigPropertyCollections/WebConfigPropertyCollections.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DscConfig.Demo.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscDiagnostic/DscDiagnostic.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/LocalGroups/LocalGroups.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/Scripts/Scripts.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscLcmMaintenanceWindows/DscLcmMaintenanceWindows.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/PSGetModuleInfo.xml
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/EnvironmentVariables/EnvironmentVariables.schema.psm1
  • output/RequiredModules/FileSystemDsc/1.1.0/en-US/about_FileSystemDsc.help.txt
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsEventLogs/WindowsEventLogs.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsEventLogs/WindowsEventLogs.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsFeatures/WindowsFeatures.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/LocalGroups/LocalGroups.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/ConfigurationBase/ConfigurationBase.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/FilesAndFolders/FilesAndFolders.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebApplicationPools/WebApplicationPools.psd1
  • output/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/en-US/DSC_FileSystemAccessRule.strings.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/NetworkIpConfiguration/NetworkIpConfiguration.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebConfigProperties/WebConfigProperties.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebApplicationPools/WebApplicationPools.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscLcmController/DscLcmController.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/ComputerSettings/ComputerSettings.schema.psm1
  • output/RequiredModules/FileSystemDsc/1.1.0/FileSystemDsc.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DscConfig.Demo.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SecurityBase/SecurityBase.psd1
  • output/RequiredModules/FileSystemDsc/1.1.0/Modules/DscResource.Common/0.16.0/en-US/DscResource.Common.strings.psd1
  • output/RequiredModules/FileSystemDsc/1.1.0/en-US/FileSystemDsc.strings.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebSites/Websites.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/FileSystemObjects/FileSystemObjects.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/NetworkIpConfiguration/NetworkIpConfiguration.psd1
  • output/RequiredModules/FileSystemDsc/1.1.0/en-US/about_FileSystemObject.help.txt
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebConfigProperties/WebConfigProperties.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SoftwarePackages/SoftwarePackages.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/Scripts/Scripts.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SecurityBase/SecurityBase.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebApplications/WebApplications.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscTagging/DscTagging.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WindowsFeatures/WindowsFeatures.schema.psm1
  • output/RequiredModules/FileSystemDsc/1.1.0/Modules/DscResource.Common/0.16.0/DscResource.Common.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscDiagnostic/DscDiagnostic.schema.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/WebVirtualDirectories/WebVirtualDirectories.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/EnvironmentVariables/EnvironmentVariables.psd1
  • output/RequiredModules/FileSystemDsc/1.1.0/DSCResources/DSC_FileSystemAccessRule/DSC_FileSystemAccessRule.psm1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/LocalUsers/LocalUsers.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/FilesAndFolders/FilesAndFolders.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/SmbShares/SmbShares.psd1
  • output/RequiredModules/DscConfig.Demo/0.8.3/DSCResources/DscLcmMaintenanceWindows/DscLcmMaintenanceWindows.psd1

Comment on lines +6 to 9
FilesAndFolders:
Items:
- DestinationPath: '[x= "C:\Test\$($File.BaseName)-Environment" =]'
Type: Directory
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Update the consumer docs for the FilesAndFolders rename.

FilesAndFolders replaces a public Datum key, but the PR checklist still marks README/schema/help updates as unfinished. Merging the rename without those updates will leave users with stale examples and parameter descriptions.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@source/Environment/Dev.yml` around lines 6 - 9, The template renames a public
Datum key to FilesAndFolders but the consumer docs and schema/help examples
weren’t updated; update all consumer-facing documentation (README, schema
definitions, help text and any example YAML/JSON) to replace the old Datum key
with FilesAndFolders, adjust parameter descriptions and examples to match the
new DestinationPath structure and semantics, and mark the PR checklist items as
completed (README/schema/help) so users don’t see stale examples or parameter
names.

@raandree raandree merged commit db9b259 into dsccommunity:main Mar 12, 2026
5 checks passed
@raandree raandree deleted the feature/CommonTasks branch March 12, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant