Integrates text-security npm module to Secrets component#304
Open
rewanthtammana wants to merge 3 commits intodrone:vuefrom
Open
Integrates text-security npm module to Secrets component#304rewanthtammana wants to merge 3 commits intodrone:vuefrom
rewanthtammana wants to merge 3 commits intodrone:vuefrom
Conversation
rewanthtammana
force-pushed
the
integrate-text-security
branch
from
89ade58 to
64916b6
Compare
Prevents shoulder surfing
rewanthtammana
force-pushed
the
integrate-text-security
branch
from
64916b6 to
5b0a004
Compare
tboerger
reviewed
Jul 28, 2019
Author
|
@tboerger I wasn't familiar with VUE, so I faced issues in importing node_modules. After digging up a bit, I found a new way and its working like a charm. Just removing the "~" did the job perfectly. Please check it. |
Author
|
@bradrydzewski @tboerger any changes required for the code? any updates? |
tboerger
approved these changes
Aug 6, 2019
tboerger
left a comment
tboerger
left a comment
There was a problem hiding this comment.
I would name the class hide-secret, but besides that LGTM
Author
Done. I was more associated with JS, so just got used to JS coding conventions. |
|
cool 👍 |
|
The change looks great, is anyone merging this soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hides the sensitive secret information while typing as password disc symbols to prevent shoulder surfing.
@bradrydzewski @tboerger There were some compilation errors when I tried to include svg, eot and ttf font files. It seems they require updated version of file-loader and url-loader modules. ( Ref: webpack/webpack#6419 ). The latest version of both the modules are added to package.json
Closes #302
cc: @HrushikeshK