ci: drop SOCKS5 tunnel build from prebuild workflow (fix for #13)#14
Merged
Merged
Conversation
The hev-socks5-tunnel submodule and HevSocks5Tunnel.xcframework live on the unmerged timo/socks5-vpn branch, not on master. prebuild-r2.yml (added in #13) is master-based, where WebDriverAgentRunner does not link the WebDriverAgentTunnel appex, there is no .gitmodules, and Scripts/build-hev-socks5-tunnel.sh does not exist — so the "Build SOCKS5 tunnel xcframework" steps would fail the build immediately. Remove them. build-real.sh / build-sim.sh build the runner schemes directly with no tunnel dependency on master. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fix for #13.
The bug
#13 added "Build SOCKS5 tunnel xcframework" steps (running
Scripts/build-hev-socks5-tunnel.shwith asubmodules: recursivecheckout) before the iOS runner builds. That was based on the wrong assumption that this line carries the SOCKS5 tunnel.It does not. The tunnel — the
hev-socks5-tunnelsubmodule,HevSocks5Tunnel.xcframework, theWebDriverAgentTunnelappex, andScripts/build-hev-socks5-tunnel.sh— lives only on the unmergedtimo/socks5-vpnbranch. Onmaster(where this workflow runs):.gitmodules, no submoduleWebDriverAgentTunneltarget in the Xcode projectScripts/build-hev-socks5-tunnel.shSo the added steps would have failed the
build-real/build-simjobs on the very first run.The fix
Remove the two tunnel-build steps.
Scripts/ci/build-real.shandScripts/ci/build-sim.shbuild theWebDriverAgentRunner/WebDriverAgentRunner_tvOSschemes directly, with no tunnel dependency on master. Thesubmodules: recursivecheckout is left in place — it's a harmless no-op today and is ready if the tunnel work later merges to master (at which point the build step can be reintroduced).Diff:
1 file changed, 9 deletions(-).🤖 Generated with Claude Code