Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: 更新版本号至 0.8.13,并增强 QEMU UEFI 支持 #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
chore: 更新版本号至 0.8.13,并增强 QEMU UEFI 支持 #42
Changes from all commits
426874ea127bd9File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With
uefi = true, this path copiesctx.paths.artifacts.binintoEFI/BOOT/BOOT*.EFI, but in this codebaseobjcopy_output_bin()produces a raw-O binaryimage, not a PE/COFF EFI executable. Because the commit also disables the-kernelloader in UEFI mode, default workflows (to_bin = true) now hand OVMF a non-EFI file and the VM will fail to boot for existing ELF-based kernels.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This helper unconditionally calls
self.ctx.metadata()before computing the artifact directory, so UEFI runs now fail insystem = "Custom"projects that do not have aCargo.tomlinmanifest(a supported mode). Previously the UEFI preparation path did not depend on Cargo metadata, so this introduces a regression for non-Cargo custom build workflows.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.