Use bulk issue-add endpoint for adding issues to Wave Programs#1946
Open
efstajas wants to merge 1 commit into
Open
Use bulk issue-add endpoint for adding issues to Wave Programs#1946efstajas wants to merge 1 commit into
efstajas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend half of drips-network/wave#735 — requires drips-network/wave#739 to be deployed first.
Change
The "add issues to Wave Program" flow now sends one
POST /wave-programs/:id/issues/bulkrequest per chunk of 50 issues (the server's cap), sequentially, instead of one request per issue. Each chunk is a single backend transaction with a single org-lock acquisition, so bulk adds no longer pile up advisory-lock waiters server-side (the cause of today's statement-timeout 503 storms; #1945 was the stopgap).addIssuesToWaveProgramutil + response schemas in$lib/utils/wave.resultsand feed the same partial-failure error screen as before; whole-chunk failures (network/5xx) mark just that chunk's issues as failed while other chunks proceed.wave:issuesinvalidated exactly as before, including on partial failure.mapWithConcurrencyfrom throttle bulk wave issue adds #1945 is left in place (generic, tested util) but the add flow no longer uses it.Testing
npm run check,eslint,prettierclean; unit tests pass (106).Deploy order
Backend drips-network/wave#739 must ship first — this flow 404s against an API without the bulk route.