-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: underline selection #5818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
View Deployment
|
b9530bc to
e2b94c1
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #5818 +/- ##
==========================================
- Coverage 33.30% 33.28% -0.02%
==========================================
Files 2761 2763 +2
Lines 144913 144959 +46
Branches 32345 32355 +10
==========================================
- Hits 48265 48254 -11
- Misses 96648 96705 +57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jikkai |
|
Apologies for the late reply. I’ve been handling a few other priorities 🤧 From a review perspective your implementation looks perfectly fine. However, as it may relate to Univer Docs import/export, we’ll need a little extra time to review the implications :) |
|
@jikkai I understand you, I will wait for an answer on this issue =) Considering that I also did import and export on my backend, I think it will not affect you for long, since your underscore types were initially well designed. I think the only issue is in supporting the necessary switch-case types |
…underline picker to dark theme
|
It's weird, this test used to work fine, but I don't think I added anything that would have broken it. |
This is an issue caused by pixel comparison. As long as the content in the examples of docs or sheets is modified, resulting in changes to the rendering of the visible area, this problem will be triggered. |
|
Thanks, then I'll wait for confirmation of this decision. I think it's gotten better after the last change. I also have a suggestion regarding underscores in tables, since Excel also supports double underscores. |
|
@VicKun4937 |
|
I think this can be closed... |


close #xxx
I continued implementing text underlining, considering the possibility of installing different options for underlining, it seemed logical to me to have a drop-down list of possible options
If this implementation is suitable, I can add this in sheets
I hope you like this implementation, I personally like it =)
open demo -> try use underline
Screencast.from.2025-09-07.21-07-33.webm
Pull Request Checklist