This repository was archived by the owner on Sep 25, 2024. It is now read-only.
Fixed module compatibility with tide_edit_protection. - #15
Open
joshua1234511 wants to merge 1 commit into
Open
joshua1234511 wants to merge 1 commit into
joshua1234511 wants to merge 1 commit into
Conversation
sonnykt
suggested changes
Nov 15, 2021
| $this->contentLoader->setContentPath($temp_dir); | ||
| $entities = $this->contentLoader->loadContent($temp_name); | ||
| $this->messenger()->addMessage($this->formatPlural(count($entities), '1 demo entity has been imported.', '@count demo entities have been imported.') . ' Only node and media type entities are listed below - '); | ||
| $this->messenger()->addMessage($this->t($this->formatPlural(count($entities), '1 demo entity has been imported.', '@count demo entities have been imported.') . ' Only node and media type entities are listed below - ')); |
Contributor
There was a problem hiding this comment.
This approach is invalid. formatPlural() should not be wrapped inside a t().
The issue is caused by tide_edit_protection module hence the fix must be in that module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
When tide_edit_protection and tide_demo_content both are enabled. error is thrown on page /admin/content/import_demo_content.
Though content gets imported the error is noticed.
Changed: Added translation.
Issue Resolved