Add support for DECSCUSR (Set Cursor Style) - #21
Open
reubeno wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This set of changes adds support for
DECSCUSR(CSI Ps SP q):ESC [ 0 ␣ q- terminal defaultESC [ 1 ␣ q- blinking blockESC [ 2 ␣ q- steady blockESC [ 3 ␣ q- blinking underlineESC [ 4 ␣ q- steady underlineESC [ 5 ␣ q- blinking barESC [ 6 ␣ q- steady barI've tried to model the code changes on how mouse modes are currently implemented, as this seemed like a natural analogue. I see that cursor hiding is represented as mode bits, but this didn't seem to be fit well with that.
(This is my first contribution to this project, so I'd appreciate any pointers for additional tests I should be authoring or other consideration. Thanks!)
References