Add option to keep the child process alive#837
Open
sebastienros wants to merge 3 commits intomainfrom
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to optionally keep child processes alive after the main benchmark job completes. The feature allows users to specify whether a tracked child process should be terminated or kept running when the benchmark finishes.
- Adds a new
KeepChildProcessAliveboolean property to the Job model with a default value of false - Updates the EventSource API to accept an optional
keepAliveparameter when setting child process IDs - Modifies the job termination logic to skip killing child processes when the keep-alive flag is enabled
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Crank.Models/Job.cs | Adds the KeepChildProcessAlive property to the Job class |
| src/Microsoft.Crank.Jobs.Bombardier/Microsoft.Crank.Jobs.Bombardier.csproj | Updates C# language version to Latest |
| src/Microsoft.Crank.EventSources/Microsoft.Crank.EventSources.csproj | Updates C# language version to Latest |
| src/Microsoft.Crank.EventSources/BenchmarksEventSource.cs | Modifies SetChildProcessId method to accept optional keepAlive parameter |
| src/Microsoft.Crank.Controller/README.md | Documents the new --[JOB].keepChildProcessAlive command-line option |
| src/Microsoft.Crank.Controller/Documentation.cs | Adds documentation for the new keep-alive option |
| src/Microsoft.Crank.Agent/Startup.cs | Implements parsing logic and termination behavior for the keep-alive feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
LoopedBard3
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.