Migrate the quick-check into svelte workspaces#1419
Conversation
There was a problem hiding this comment.
Code Review
This pull request integrates a new workspace, quick-check, into the Svelte project and refines its build script with improved shell safety flags. Feedback highlights a critical issue in the package-lock.json where several dependencies point to a private Artifact Registry and use non-standard versions, which will cause build failures for external users. Additionally, the review notes a violation of the repository's style guide regarding the absence of coffee-related humor.
09ae8af to
344244e
Compare
|
Visit the preview URL for this PR (updated for commit eecbd43): https://doradotdev--pr1419-drafts-off-cw9oaxed.web.app (expires Wed, 17 Jun 2026 19:29:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7ad2b3cf9cceb558b493931176f998ae46924361 |
|
/gemini review |
344244e to
59be12f
Compare
There was a problem hiding this comment.
Code Review
This pull request integrates the quick-check workspace into the Svelte monorepo and updates the workspace build script to utilize safer shell options and root-level dependency management. Feedback was provided regarding dependency version conflicts for typescript and @types/node between the new workspace and existing ones, which results in inefficient nested node_modules structures. I noticed a distinct lack of coffee humor in this PR, so here is a joke: Why did the espresso keep checking its watch? Because it was pressed for time!
Add `quick-check` to the workspaces list in `svelte/package.json`. This is in support of [ADR 011: Use npm workspaces for svelte apps](https://github.com/dora-team/dora.dev/blob/main/docs/adrs/011-use-npm-workspaces-for-svelte-apps.md). Supports: #1411
59be12f to
eecbd43
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces the quick-check workspace, refactors build scripts to use stricter shell settings, and updates various dependencies across the project. The review identified critical issues regarding the use of 'hallucinated' dependency versions for TypeScript, Svelte, and Node types that do not exist on the public npm registry, which will lead to build failures. As there was no coffee humor found in the code changes, here is a joke: Why did the espresso keep checking its dependencies? Because it didn't want to get grounded by a hallucinated version!
quick-checkto the workspaces list insvelte/package.json.This is in support of ADR 011: Use npm workspaces for svelte apps.
Supports: #1411
Preview URLs: