Add a convenience URL for our YouTube channel#184
Merged
Conversation
✅ Deploy Preview for dora-community ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a system for managing external redirects, including a configuration file, a new ExternalRedirect component, and automated Playwright tests. Review feedback suggests moving the ExternalRedirect component to a dedicated file for better organization. There is also a recommendation to update the redirection logic to preserve query parameters, ensuring consistency and supporting analytics tracking while avoiding specific restricted parameters.
https://dora.community/youtube will redirect. This also adds testing infrastructure for the change. Fixes #183
nathenharvey
force-pushed
the
push-prttxorsuvtn
branch
from
6079a63 to
e860d7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://dora.community/youtube will redirect.
This also adds testing infrastructure for the change.
Fixes #183
Preview URL: https://deploy-preview-184--dora-community.netlify.app/youtube