Skip to content

Add saya to dojoup install script#3399

Merged
kronosapiens merged 1 commit intodojoengine:mainfrom
kronosapiens:add-saya-to-install
Mar 5, 2026
Merged

Add saya to dojoup install script#3399
kronosapiens merged 1 commit intodojoengine:mainfrom
kronosapiens:add-saya-to-install

Conversation

@kronosapiens
Copy link
Contributor

@kronosapiens kronosapiens commented Mar 5, 2026

Summary

  • Add saya to the PLUGINS list in dojoup/install
  • The dojoengine/asdf-saya plugin already exists and works correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added support for the saya plugin to the installation process, enabling access to additional functionality during setup.

Include saya in the list of asdf plugins installed by the toolchain
installer.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

Ohayo, sensei! Let me break down this change for you.

Walkthrough

The PLUGINS array in dojoup/install was updated to include the saya plugin alongside the existing sozo, katana, and torii plugins. This single-line addition expands the asdf installation loop to process four plugins instead of three, with all downstream logic processing the updated array unchanged.

Changes

Cohort / File(s) Summary
Plugin Array Update
dojoup/install
Added saya plugin to the PLUGINS array, expanding from three to four plugins (sozo, katana, torii, saya) in the asdf installation loop.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: adding the saya plugin to the dojoup install script, which matches the file modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@dojoup/install`:
- Line 19: The installer PLUGINS array was updated to include "saya"
(PLUGINS=(sozo katana torii saya)) but the component list in dojoup/dojoup
remains ("sozo" "torii" "katana"); update the component definitions in
dojoup/dojoup to include "saya" so both installer paths are consistent, locate
the component array or function that returns the list (e.g., the components
variable or get_components()/define_components() block in dojoup/dojoup) and add
"saya" in the same ordering used by the installer.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0a7d8fee-8292-4a92-8b42-2139fc2872db

📥 Commits

Reviewing files that changed from the base of the PR and between afbb9ce and 026b2e6.

📒 Files selected for processing (1)
  • dojoup/install

@kronosapiens kronosapiens merged commit 4a374ac into dojoengine:main Mar 5, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants