Add saya to dojoup install script#3399
Conversation
Include saya in the list of asdf plugins installed by the toolchain installer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Ohayo, sensei! Let me break down this change for you. WalkthroughThe PLUGINS array in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@dojoup/install`:
- Line 19: The installer PLUGINS array was updated to include "saya"
(PLUGINS=(sozo katana torii saya)) but the component list in dojoup/dojoup
remains ("sozo" "torii" "katana"); update the component definitions in
dojoup/dojoup to include "saya" so both installer paths are consistent, locate
the component array or function that returns the list (e.g., the components
variable or get_components()/define_components() block in dojoup/dojoup) and add
"saya" in the same ordering used by the installer.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0a7d8fee-8292-4a92-8b42-2139fc2872db
📒 Files selected for processing (1)
dojoup/install
Summary
sayato the PLUGINS list indojoup/installdojoengine/asdf-sayaplugin already exists and works correctly🤖 Generated with Claude Code
Summary by CodeRabbit