Skip to content

Fix dockerized windows builds #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krissetto merged 1 commit into from
Dec 2, 2025
+6 −2
Merged

Fix dockerized windows builds #1008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ FROM builder-$TARGETOS AS builder

FROM scratch AS local
ARG TARGETOS TARGETARCH
COPY --from=builder /binaries/cagent-$TARGETOS-$TARGETARCH cagent
COPY --from=builder /binaries/cagent-$TARGETOS-$TARGETARCH* cagent

FROM scratch AS cross
COPY --from=builder /binaries .
Expand Down
2 changes: 1 addition & 1 deletion Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ tasks:

build-local:
desc: Build binaries for local host platform
cmd: docker buildx build --target=local {{.BUILD_ARGS}} --platform local --output=./dist .
cmd: docker buildx build --target=local {{.BUILD_ARGS}} --platform local --output=./dist . {{if eq OS "windows"}}&& mv ./dist/cagent ./dist/cagent.exe{{end}}

cross:
desc: Build binaries for multiple platforms
Expand Down
4 changes: 4 additions & 0 deletions docs/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ If you're hacking on `cagent`, or just want to be on the bleeding edge, then bui
- [Task 3.44 or higher](https://taskfile.dev/installation/)
- [`golangci-lint`](https://golangci-lint.run/docs/welcome/install/#binaries)

> Note: On windows, we currently only support building from source via docker with `task build-local`
>
> See [here](#building-with-docker) for more details

##### Build commands

```bash
Expand Down