Better file attachment support with @somefile
#1004
Merged
+386
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Hide completion menu when no items match the query - Include @ prefix in file completion value (since handler removes trigger) - Expand file references with actual file contents when sending message Signed-off-by: Christopher Petito <[email protected]>
rumpl
reviewed
Dec 1, 2025
| cmd := p.processMessage(msg.Content) | ||
| return p, cmd | ||
| // Add user message to UI immediately using the display content (with @filename placeholders) | ||
| displayCmd := p.messages.AddUserMessage(msg.DisplayContent) |
Member
There was a problem hiding this comment.
Is this change needed for this feature? I guess it's fine to have optimistic rendering, my idea of the UserMessageEvent was for times when you connect the tui to a remote server
Contributor
Author
There was a problem hiding this comment.
yeah good Q, honestly i didn't think too much about it.. maybe we should consolidate and have only one way to do things
Member
There was a problem hiding this comment.
What do you mean only one way to do things? We do have one way to do things: react to the events sent from the runtime :D
rumpl
reviewed
Dec 1, 2025
| case *runtime.UserMessageEvent: | ||
| cmd := p.messages.AddUserMessage(msg.Message) | ||
| return p, cmd | ||
| // User message is already added in the SendMsg handler with display content, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes @ references for files actually send the file contents along with the message to the LLM, so the agent doesn't have to round-trip to then get the files contents (if it has access to a tool with which to do that).
Files references via @somefile get attached to a structured section at the end of the user message, while the @somefile references remain in the message where the user typed them so the LLM has a better idea of the context and where the file contents are referenced by the user
Full attachment contents are not shown in the TUI to keep things easier to read
Also fixes a visual bug where historical completions were showing alongside @ file completions
Example
What the user sees:
What actually gets sent as the contents of the user message: