dap: Fix breakpoint overlap check #3534
Open
+136
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
previously approved these changes
Nov 24, 2025
The old logic wasn't quite right, and a little hard to follow. Before this, because breakpoints sent from setBreakpoints don't have an end line or column they are just a single point the comparison would fail the check due to the column check. E.g. if I have a breakpoint on line 30. The content lines range from 29-31. Now lets say the end column is at postion 10, but my breakpoint is at L30 column 11 (still within range). The overlap check would fail because 11 > 10 but these shouldn't be compared at all in this case. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
dap_bp_overlaps
branch
from
0b07a95 to
8d822eb
Compare
Contributor
Author
|
Added a test. |
jsternberg
approved these changes
Nov 26, 2025
tonistiigi
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old logic wasn't quite right, and a little hard to follow. Before this, because breakpoints sent from setBreakpoints don't have an end line or column they are just a single point the comparison would fail the check due to the column check.
E.g. if I have a breakpoint on line 30.
The content lines range from 29-31.
Now lets say the end column is at postion 10, but my breakpoint is at L30 column 11 (still within range).
The overlap check would fail because 11 > 10 but these shouldn't be compared at all in this case.