Skip to content

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Nov 13, 2025

Comment on lines 426 to 427
meta-images: |
${{ env.REPO_SLUG }}
Copy link
Member Author

@crazy-max crazy-max Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crazy-max crazy-max force-pushed the bin-image-github-builder branch 3 times, most recently from 96dacaf to acc33b1 Compare November 13, 2025 13:04
@crazy-max
Copy link
Member Author

crazy-max commented Nov 13, 2025

GitHub hosted runner doesn't have enough space to build our image: https://github.com/docker/buildx/actions/runs/19330419315/job/55292703625#step:8:521

#28 [linux/amd64->darwin/amd64 buildx-build 1/1] RUN --mount=type=bind,target=.   --mount=type=cache,target=/root/.cache   --mount=type=cache,target=/go/pkg/mod   --mount=type=bind,from=buildx-version,source=/buildx-version,target=/buildx-version <<EOT (set -e...)
#28 1051.0 k8s.io/api/autoscaling/v2beta1: mkdir /tmp/go-build135885827/b986/: no space left on device

Hence why we free up disk space currently (see #3040)

For our reusable workflow, one way to fix it would be to distribute build across runners: docker/github-builder-experimental#2

@crazy-max
Copy link
Member Author

Switch reusable workflow ref to bake-distrib docker/github-builder-experimental#22 so builds are distributed across runners.

@crazy-max crazy-max force-pushed the bin-image-github-builder branch 4 times, most recently from e491c64 to fe39cf7 Compare November 15, 2025 19:02
@crazy-max crazy-max requested a review from tonistiigi November 16, 2025 09:16
@crazy-max crazy-max force-pushed the bin-image-github-builder branch from fe39cf7 to a657c7e Compare November 16, 2025 10:35
@crazy-max crazy-max changed the title ci: use docker github builder to build bin image ci: use docker github builder to build bin image and binaries Nov 16, 2025
@crazy-max
Copy link
Member Author

Pushed extra commit to also build our binaries with our reusable workflow.

@crazy-max crazy-max marked this pull request as ready for review November 16, 2025 10:51
@crazy-max crazy-max force-pushed the bin-image-github-builder branch 4 times, most recently from d696d03 to 9a64ed8 Compare November 28, 2025 13:24
@crazy-max crazy-max force-pushed the bin-image-github-builder branch from 9a64ed8 to 9d72d10 Compare December 1, 2025 11:15
@crazy-max crazy-max added this to the v0.31.0 milestone Dec 2, 2025
runner: amd64
target: release
output: local
push: ${{ github.event_name != 'pull_request' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one shouldn't be here right?

Suggested change
push: ${{ github.event_name != 'pull_request' }}

Copy link
Contributor

@dvdksn dvdksn Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see:

https://github.com/docker/github-builder-experimental/blob/36714dbaf49f1f3518cd865748c85b863cdbcbe4/.github/workflows/bake.yml#L36C69-L36C117

Something like sign-artifacts: ${{ github.event_name != 'pull_request' }} might be more intuitive, splitting push and manifest signing for local artifacts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I'm working on refactoring the UX, I don't really like push as well, that's misleading. I will open an issue on github-builder repo to address this 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants