Warn in the input status when Pi stops producing output - #299
Open
dnouri wants to merge 2 commits into
Open
Conversation
Warn in the existing input-header status after five minutes of stdout silence while streaming or compacting. Keep the current phase visible, use the warning face, and provide help for manual abort. Add `pilish-session-inactivity-timeout` (positive seconds; nil disables). Any nonempty stdout resets the quiet interval. Tools and subagents may still be working; this is only an advisory warning, with no backend polling, automatic abort, or lifecycle changes. Validated with 1,780 passing unit tests (one existing skip), fake RPC integration, tool-update correctness smoke, and real-process input-header smoke covering silence, recovery, abort, concurrent sessions, and session transitions. Fixes #253.
Warn in the existing input-header status after five minutes of stdout silence while streaming or compacting. Keep the current phase visible, use the warning face, and provide help for manual abort. Configure `pilish-session-inactivity-timeout` with positive seconds, or nil to disable it. Any nonempty stdout resets the quiet interval. Tools and subagents may still be working; the warning never polls the backend, aborts work, or changes session lifecycle state. Simplify timer ownership and cancel abandoned observers when chat buffers lose their local state or are killed. Keep monitoring limited to active sessions. Replace the simulated test scheduler with real timers and focused allocation checks, preserving coverage for duplicate observers and timer churn. Validated with 1,784 passing unit tests (one existing skip), fake RPC integration, tool-update correctness smoke, and real-process input-header smoke covering silence, recovery, abort, concurrent sessions, session transitions, and abandoned-timer cleanup. Independent mutation checks cover timer cadence, rendering errors, protocol literals, and allocation behavior. Fixes #253.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warn in the existing input-header status after five minutes of stdout silence while streaming or compacting. Keep the current phase visible, use the warning face, and provide help for manual abort.
Configure
pilish-session-inactivity-timeoutwith positive seconds, or nil to disable it. Any nonempty stdout resets the quiet interval. Tools and subagents may still be working; the warning never polls the backend, aborts work, or changes session lifecycle state.Simplify timer ownership and cancel abandoned observers when chat buffers lose their local state or are killed. Keep monitoring limited to active sessions. Replace the simulated test scheduler with real timers and focused allocation checks, preserving coverage for duplicate observers and timer churn.
Validated with 1,784 passing unit tests (one existing skip), fake RPC integration, tool-update correctness smoke, and real-process input-header smoke covering silence, recovery, abort, concurrent sessions, session transitions, and abandoned-timer cleanup. Independent mutation checks cover timer cadence, rendering errors, protocol literals, and allocation behavior.
Fixes #253.