Fixed incorrect return values #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed incorrect non-reference return values causing null reference errors when being cast to T in GetItem<T>()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using GetImage(), GetContainer(),GetSlider(), and GetToggle(), the Unity UI component is returned, instead of the expected reference types.
Using GetImage() as an example, GetItem() is only ever called with T being an ImageReference type, ContainerReference type, etc.
When GetImage(roleValue) returns an Image, it then gets cast to type ImageReference, and fails because the two types aren't compatible, thus creating a NullReferenceException.
Furthermore, there was a previous fix to this (Images only, not containers/sliders/toggles) by creating a new method called GetImageReference() and replacing GetImage() in GetItem() with it. However, GetImage() is not used elsewhere, so I have fixed GetImage() as the other methods do not have GetXReference() in their name in the current convention, and removed the GetImageReference() method.