Non-blocking FPS limiter#4994
Open
jwt27 wants to merge 8 commits into
Open
Conversation
That makes way more sense. I don't know what I was thinking.
This allows higher frameskip values.
rainlizard
approved these changes
Jul 8, 2026
Member
|
@jwt27 I tested it, and joined a LAN game with myself twice. I increased frameskip as red, and did not do anything yet with blue. Then playing as red became impossible, very laggy controls. |
Contributor
Author
Because the frameskip value is not communicated over the network. One side can enable it (and slow down viewport controls) but doesn't know that the other hasn't. This behavior is the same in alpha 5192, not a regression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4919. This patch rewrites the frame rate limiter and makes it non-blocking, so that it doesn't interfere with networking. It also now works with fast-forward.