Fix rate limit validation error for unlimited accounts#8
Open
jmazzahacks wants to merge 1 commit intodingo-actual:mainfrom
Open
Fix rate limit validation error for unlimited accounts#8jmazzahacks wants to merge 1 commit intodingo-actual:mainfrom
jmazzahacks wants to merge 1 commit intodingo-actual:mainfrom
Conversation
Fixes Pydantic validation error when OpenRouter API returns requests=-1 (indicating unlimited rate limits). Instead of passing -1 to SmartSurge which fails validation (max_requests must be >= 1), now: - Checks if requests <= 0 and skips rate limit configuration - Logs debug message indicating unlimited rate limit detected - Prevents "Failed to set rate limit" validation errors This resolves the recurring error logs while preserving functionality for accounts with standard rate limits. Contributed by @jmazzahacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a Pydantic validation error that occurs when the OpenRouter API returns
requests: -1to indicate unlimited rate limits.Problem
The client encounters validation errors when OpenRouter returns
-1for unlimited accounts:Solution
Added a simple check in
_initialize_rate_limit()to skip rate limit configuration whenrequests <= 0:Testing
Confirmed the fix resolves the validation errors for unlimited accounts while maintaining functionality for standard rate-limited accounts.
Contributed by @jmazzahacks