Repository navigation
Conversation
Adoption companion for agentrust-io#805; preserve the original author's branch and scope. Signed-off-by: Srinivasa Dinakar Jainti <dinakarjs@gmail.com> Signed-off-by: Srinivasa Consultants <78673153+dinakarjs@users.noreply.github.com>
|
🟡 Contributor Check: MEDIUM
Automated check by AgenTrust Contributor Check. |
github-actions
Bot
added
the
needs-review:MEDIUM
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adoption companion for agentrust-io#805 at d61268c, addressing Rajnish's two outstanding review requests. This is not a competing upstream PR.
Require TPM_ST_ATTEST_QUOTE in the parsed attestation and explicit kty=RSA in HCLAkPub. Three new signed synthetic cases pair a valid quote/key with the requested refusal; both bare and TPM2B-wrapped attestation forms are exercised. Their signatures and runtime binding are recomputed, so an unrelated invalid-signature failure does not mask either predicate.
Validation on tree 1581318780eb68af1423a9b0212656e712f5e117: three new cases pass normally and under -O; the Azure verifier selection passes 11 cases with one optional hardware skip. Restoring only the old quote parser makes the two attestation-kind cases fail, and restoring only the old HCL-key parser makes the missing-kty case fail. Ruff, strict mypy (77 files) and configured Bandit pass. Final full unit suite on the submitted tree: 2607 passed / 8 skipped. The final strengthened assertion also passes in the three new normal/-O cases; upstream review comment links this exact candidate and result. No live Azure/TPM evidence, optional no-nonce contract change or independent approval of this contribution is claimed.
Please cherry-pick the single signed commit into the existing agentrust-io#805 branch and rerun its exact-head checks. Prepared with OpenAI Codex; author adoption and independent review remain required.