Repository navigation
Conversation
Signed-off-by: Srinivasa Consultants <78673153+dinakarjs@users.noreply.github.com>
|
🟡 Contributor Check: MEDIUM
Automated check by AgenTrust Contributor Check. |
github-actions
Bot
added
the
needs-review:MEDIUM
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public-key alias fixture previously changed the signed JWK without refreshing its signature, so signature failure could mask the encoding check. Re-sign the altered claim and recompute the corresponding nonce thumbprint; assert the alias decodes to the same key bytes. This independently exercises signature-path and key-binding canonicality. Also correct the test import ordering.
Based exactly on agentrust-io#808 head 4d37e36. Please adopt this signed test-only commit into that PR.
Validation: final unit+conformance+integration+confinement suite 2654 passed/29 skipped. Ruff src/tests, strict mypy and Bandit pass. Disabling only signature-path key canonicality makes the signature assertion fail; separately disabling only key-binding canonicality makes the binding assertion fail, retaining all test names. Both guard removals are reverted.