Skip to content

fix: zenoh forking issue - #3503

Open
paul-nechifor wants to merge 1 commit into
mainfrom
paul/fix/zenoh-fork-issue
Open

fix: zenoh forking issue#3503
paul-nechifor wants to merge 1 commit into
mainfrom
paul/fix/zenoh-fork-issue

Conversation

@paul-nechifor

Copy link
Copy Markdown
Contributor

Problem

The Coordinator RPC is broken when using Zenoh.

Closes #3395

Solution

Start the Zenoh sessions (i.e. call ModuleCoordinator.build) only after forking.

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.97403% with 37 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
dimos/cli/dimos.py 55.35% 23 Missing and 2 partials ⚠️
dimos/core/test_daemon_zenoh.py 65.62% 10 Missing and 1 partial ⚠️
dimos/core/daemon.py 96.00% 0 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main    #3503      +/-   ##
==========================================
+ Coverage   74.05%   76.08%   +2.03%     
==========================================
  Files        1283     1225      -58     
  Lines      124704   118860    -5844     
  Branches    11141    10660     -481     
==========================================
- Hits        92349    90435    -1914     
+ Misses      29493    25350    -4143     
- Partials     2862     3075     +213     
Flag Coverage Δ
OS-ubuntu-24.04-arm 70.48% <75.97%> (+0.04%) ⬆️
OS-ubuntu-latest 72.27% <75.97%> (+0.04%) ⬆️
Py-3.10 72.26% <75.97%> (+0.05%) ⬆️
Py-3.11 72.26% <75.97%> (+0.05%) ⬆️
Py-3.12 72.26% <75.97%> (+0.04%) ⬆️
Py-3.13 72.26% <75.97%> (+0.04%) ⬆️
Py-3.14 72.26% <75.97%> (+0.04%) ⬆️
Py-3.14t 72.26% <75.97%> (+0.04%) ⬆️
SelfHosted-Large 29.74% <21.42%> (+0.03%) ⬆️
SelfHosted-Linux 35.82% <21.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dimos/core/demos/stress_test_module.py 89.47% <ø> (-1.01%) ⬇️
dimos/core/test_daemon.py 99.18% <100.00%> (+0.07%) ⬆️
dimos/protocol/service/test_zenohservice.py 100.00% <100.00%> (ø)
dimos/protocol/service/zenohservice.py 75.42% <100.00%> (+1.08%) ⬆️
dimos/core/daemon.py 91.93% <96.00%> (+27.64%) ⬆️
dimos/core/test_daemon_zenoh.py 65.62% <65.62%> (ø)
dimos/cli/dimos.py 66.19% <55.35%> (+1.41%) ⬆️

... and 88 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--daemon + Zenoh: Coordinator RPC service unreachable after daemonize (Dimos.connect / out-of-process clients time out)

1 participant