fix(imitation): improve collection safety and episode handling - #3497
Draft
ruthwikdasyam wants to merge 7 commits into
Draft
fix(imitation): improve collection safety and episode handling#3497ruthwikdasyam wants to merge 7 commits into
ruthwikdasyam wants to merge 7 commits into
Conversation
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #3497 +/- ##
==========================================
+ Coverage 74.05% 76.17% +2.12%
==========================================
Files 1283 1226 -57
Lines 124704 119002 -5702
Branches 11141 10670 -471
==========================================
- Hits 92349 90650 -1699
+ Misses 29493 25260 -4233
- Partials 2862 3092 +230
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 86 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
Problem
Imitation collection performed unnecessary pose/TF lookup for semantically poseless streams, could stop its recorder before final producer events, and did not clearly report an episode left open at the end of a recording. Quest disconnects could also leave stale controller engagement active, and invalid episode button mappings were silently ignored.
Solution
Recorder FIFO, overload metrics, drain guarantees, and explicit WAL checkpointing are intentionally deferred to a later change. Generic Memory recorder behavior remains unchanged.
How to Test
Run the recording inspector against a collection database:
dimos dataprep inspect /path/to/session.dbAutomated verification:
uv run pytest dimos/memory dimos/imitation dimos/teleop/quest -quv run mypy dimos/uv run pre-commit run --all-filesResults: 527 tests passed, mypy passed across 998 source files, and all pre-commit hooks passed.
AI assistance
OpenCode with GPT-5.6 Sol was used extensively for codebase analysis, implementation, merge-conflict resolution, tests, and verification. The changes and generated tests were reviewed through focused diffs, type checking, pre-commit, and the affected test suites.
Checklist