feat(damiao): support native macOS CAN transport - #3465
Open
TomCC7 wants to merge 1 commit into
Open
Conversation
❌ 16 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
TomCC7
marked this pull request as ready for review
August 14, 2026 20:31
TomCC7
requested review from
Dreamsorcerer,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
August 14, 2026 20:31
TomCC7
force-pushed
the
cc/feat/openyam-macos-support
branch
from
August 14, 2026 21:37
97ee374 to
f88d119
Compare
TomCC7
force-pushed
the
cc/feat/openyam-macos-support
branch
from
August 14, 2026 21:40
e71acfc to
0a813a5
Compare
TomCC7
force-pushed
the
cc/feat/openyam-macos-support
branch
from
August 14, 2026 21:56
0a813a5 to
6b311db
Compare
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
Problem
Damiao-based arms could only construct Linux SocketCAN transports. The macOS workaround lived above the shared hardware layer, so it did not apply coherently to every Damiao topology.
Solution
can-motor-controlto 0.0.6 on Linux and macOS.SocketCanBuson Linux and the package's native RustGsUsbBuson macOS inDamiaoWholeBodyAdapter.Co-authored with @aromeoes, whose original macOS hardware work established the transport requirements.
How to Test
Result: 91 passed, 3 deselected.
Ruff and Mypy pass on the changed modules. The repository-wide fast suite reaches 4,110 passes but is currently blocked by three failures already present in the #3463 stack: the removed
prepare_urdf_for_drakeimport and two case-sensitiveControlCoordinatortest expectations.AI assistance
Codex was used to inspect the existing implementation, design the shared transport seam, implement the change, resolve the rebase, and run tests. The resulting diff and test output were reviewed during the session.
Checklist