Simplify deploy-tag push now that git 2.49 is the floor#6875
Draft
dannyroberts wants to merge 1 commit intomasterfrom
Draft
Simplify deploy-tag push now that git 2.49 is the floor#6875dannyroberts wants to merge 1 commit intomasterfrom
dannyroberts wants to merge 1 commit intomasterfrom
Conversation
Collapses the prior init-bare + fetch + push sequence in _push_release_tag into a single clone + push, taking advantage of git clone --revision (added in git 2.49). PR #6868 made 2.49 the floor on managed machines, so the version-compat workaround is no longer needed. Per #6865 (comment). https://dimagi.atlassian.net/browse/SAAS-19703
Member
Author
|
Local performance testing from Claude Code (I didn't validate it in great detail, but the approach it took seemed generally correct.) @daniel Miller it looks like the cleaner-looking command is actually a tad slower, like ~70 ms—so basically the same speed, but not faster. (I guess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://dimagi.atlassian.net/browse/SAAS-19703
Picks up @millerdev's original suggestion on #6865. Now that #6868 / SAAS-19703 has rolled out the new git 2.49 floor across managed machines, the version-compat workaround in
_push_release_tagcan go away.The previous
git init --bare+git fetch --depth=1 --filter=blob:none ... <sha>+git pushdance is replaced bygit clone --bare --filter=blob:none --depth=1 --revision=<sha>+ push.--revisionwas added in git 2.49.This is a code-clarity change, not a perf one. Bytes-on-the-wire, on-disk size, and network round-trip count are unchanged (both versions already used
--filter=blob:none --depth=1); wall time is within noise — see comment thread for numbers.Environments Affected
None.