Add USERFLOW_TOKEN to secrets.yml, localsettings.py#6870
Conversation
| - name: TRANSIFEX_API_TOKEN | ||
| legacy_namespace: localsettings_private | ||
| - name: USERFLOW_TOKEN | ||
| legacy_namespace: localsettings_private |
There was a problem hiding this comment.
Should this be "secrets"? Or can I leave it out?
There was a problem hiding this comment.
If it never existed, I hope it can be left out. @dannyroberts can you confirm?
Possibly relevant/helpful: #4122 and linked discussions.
There was a problem hiding this comment.
I think you're right @millerdev -- I'm sure @dannyroberts would not have named it legacy namespace if it wasn't legacy. I've dropped it in 1cbf91e and opened a tiny documentation PR #6874 to clarify.
millerdev
left a comment
millerdev
left a comment
There was a problem hiding this comment.
The test failure looks related.
| PREVIEWER_RE = r'^(.*@dimagi\.com|.*@valuelabs\.in)$' | ||
| GMAPS_API_KEY = '{{ GMAPS_API_KEY }}' | ||
| MAPBOX_ACCESS_TOKEN = '{{ MAPBOX_ACCESS_TOKEN }}' | ||
| USERFLOW_TOKEN = '{{ USERFLOW_TOKEN }}' |
There was a problem hiding this comment.
Is USERFLOW_TOKEN guaranteed not to contain single quote (') characters? Or maybe they should be escaped (does Ansible provide a way to call str.__repr__)?
I realize this is following the same pattern used by other secrets and variables, which do nothing special. Feel free to ignore.
There was a problem hiding this comment.
USERFLOW_TOKEN matches /^[a-z0-9_]$/
| STRIPE_PUBLIC_KEY: "{{ localsettings_private.STRIPE_PUBLIC_KEY | default(None) }}" | ||
| SUMOLOGIC_URL: "{{ localsettings_private.SUMOLOGIC_URL | default(None) }}" | ||
| TRANSIFEX_API_TOKEN: "{{ localsettings_private.TRANSIFEX_API_TOKEN | default(None) }}" | ||
| USERFLOW_TOKEN: "{{ USERFLOW_TOKEN | default('') }}" |
There was a problem hiding this comment.
Similarly, is USERFLOW_TOKEN guaranteed not to contain double quote (") characters?
2 participants
Adds
USERFLOW_TOKENtolocalsettings.pyfor staging Userflow. Value pulled fromlocalsettings_private.Environments Affected
This is intended for Staging (but obviously an empty value will be in
localsettings.pyin all environments).Jira: SAAS-19721