Conversation
|
@AmitPhulera I'm leaning towards creating a new changelog for self hosters to run this again as opposed to updating the v24 changelog. Does that seem right to you? |
| - "deb_nodesource_com_node_*.list" | ||
| - "nodesource*.list" |
There was a problem hiding this comment.
- Are the filenames being removed dynamic, and therefore cannot be matched exactly? If not, why not use exact known-problematic filenames?
- Could it be confusing at a later time if a nodesource list was added intentionally, and then this automation caused it to be removed?
- If exact filenames are not possible, would it be possible (and make sense) to change the patterns to match specific (old) versions rather than these patterns that would seem to match any version?
There was a problem hiding this comment.
Thanks yeah this was a reflection of my lack of understanding here, which is all the more reason to keep it simple/clean and remove specific files.
| - "deb_nodesource_com_node_*.list" | ||
| - "nodesource*.list" | ||
| - "deb_nodesource_com_node_16_x.list" | ||
| - "deb_nodesource_com_node_20_x.list" |
There was a problem hiding this comment.
Looks like this list will grow over time. I wonder if we're doing something wrong or in a not-best way (other than not using containers)?
There was a problem hiding this comment.
I'm not sure it will grow, and again I have a lack of understanding here. We do not have a corresponding file for deb_nodesource_com_24_x.list in this directory. It seems that because of the change made to how we install node, it might no longer rely on files like these.
There was a problem hiding this comment.
Got it, we did something somewhere else to avoid these files going forward. Excellent!
2 participants
Followup to #6742
https://dimagi.atlassian.net/browse/SAAS-19040
aptwas hitting an error due to /etc/apt/sources.list.d containinghttp://deb.nodesource.com/node_20.xwhich was returning a 404. This change ensures references to nodesource files are removed prior to installing the new version of node. I don't see any references for v24 in /etc/apt/sources.list.d, so I suspect that is a safe change to make.Environments Affected
All
Announce New Release
to announce a new commcare-cloud release.