Add JSpecify dependency and @NullMarked annotations#11
Merged
kevinherron merged 2 commits intomasterfrom Dec 30, 2025
Merged
Conversation
Add JSpecify 1.0.0 as a dependency to enable null-safety annotations. Create package-info.java files with @NullMarked for each module's com.digitalpetri.util package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) was I solving?
The codebase lacked null-safety annotations, making it harder for consumers and tooling to reason about nullability contracts in the API. Without explicit nullability documentation, users must guess whether methods can accept or return null values.
What user-facing changes did I ship?
@NullMarkedfrom JSpecify, indicating that by default, all type usages are non-null unless explicitly annotated otherwiseThis is a non-breaking change that adds metadata only. Existing code continues to work unchanged.
How I implemented it
<dependencyManagement>section with a version propertybyteops,byteops-netty,byteops-unsigned)package-info.javafiles in each module'scom.digitalpetri.utilpackage with the@NullMarkedannotationHow to verify it
Manual Testing
mvn clean packagepassespackage-info.javafiles are included in generated JARs:Description for the changelog
Add JSpecify 1.0.0 dependency and
@NullMarkedannotations to enable null-safety documentation for all packages.