Skip to content

Conversation

@anatoly-scherbakov
Copy link
Collaborator

  • Add submodules
  • Update .gitignore
  • Use spec tests from git modules as default test targets
  • list[…]List[…] because this form is for Python ⩾ 3.10 only
  • Note about Git submodules in README.rst
  • Document addition of on_key_dropped argument and its behavior
  • Implement on_key_dropped argument
  • Adapt tests by @pchampin to cover dropped keys handler

@anatoly-scherbakov anatoly-scherbakov marked this pull request as draft November 12, 2023 21:49
@BigBlueHat
Copy link
Contributor

@anatoly-scherbakov can you rebase this on the main branch, so it doesn't include the #182 code?

@anatoly-scherbakov
Copy link
Collaborator Author

@BigBlueHat that's the reason why it's in Draft :(

It should be rebased upon #182 but Github won't allow me to do that; I think #182 has to be merged first. I will do my subsequent PRs in a proper fork of the repo. Currently, as it seems, I am using some sort of hidden fork that Github automatically creates when you try to direct your PR to upstream repo you do not control, I am not sure what exactly is going on with it.

@mielvds
Copy link
Collaborator

mielvds commented Dec 24, 2025

@anatoly-scherbakov fyi, I included a stripped down version of your implementation here to #228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants