feat: add chapkit_simple_multistep_model compose overlay#291
Draft
mortenoh wants to merge 2 commits into
Draft
Conversation
Mirrors compose.ewars.yml for the simple multistep chapkit model. Image is multi-arch on GHCR so no platform pin is needed; host port 5003 avoids collision with the EWARS overlay on 5002.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compose.multistep.yml, a docker compose overlay for the chap-models/chapkit_simple_multistep_model chapkit service, mirroring the existingcompose.ewars.ymlpattern.ghcr.io/chap-models/chapkit_simple_multistep_model:latest(public, multi-arch — noplatform:pin needed).5003:8000(EWARS holds 5002) and the same urllib healthcheck probe that EWARS ships with.How I tested
Brought the stack up with
docker compose -f compose.yml -f compose.multistep.yml up -dagainst a local DHIS2 and walked through the modeling app end-to-end:/v2/servicesregistry, template synced withhealthStatus=live,usesChapkit=true._sync_chapkit_configured_modelspulled the defaultedadditional_continuous_covariates(rainfall,mean_temperature,mean_relative_humidity) from the chapkit service onto the configured-model row.Valid import: 18/18, full import Success in 33 s.Notes
Makefilewiring (make restart/make chap-version) still references only the EWARS overlay. Intentionally leaving it alone in this PR — happy to follow up if we want the default dev stack to include this service too.mean_relative_humiditydata item, so the default configured model (which includes humidity) can't pass_validate_full_dataset. Tested against a sibling configured model withadditional_continuous_covariates=["rainfall","mean_temperature"]to bypass that. No code change needed in chap-core — just a data shape the bundled sample doesn't cover.Test plan
docker compose -f compose.yml -f compose.multistep.yml configparses cleanlymultistepcontainer reaches(healthy)status/v2/serviceslistschapkit-simple-multistep-model