-
Notifications
You must be signed in to change notification settings - Fork 164
chore: Bump http certification dependencies #3550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR bumps the HTTP certification dependencies from version 2.6 to 3.0.3 and makes the necessary breaking changes to adapt to the new API. The most significant change is removing the unused streaming_strategy field from the HttpResponse type.
- Upgraded all HTTP certification crates (
ic-certification,ic-http-certification,ic-representation-independent-hash,ic-response-verification) to version 3.0.3 - Removed the unused
streaming_strategyfield fromHttpResponsein both the Rust interface and Candid API definitions - Added
TryFromimplementations to convert between the localHttpRequest/HttpResponsetypes and theic_http_certificationlibrary types
Reviewed changes
Copilot reviewed 8 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Updated workspace dependencies to version 3.0.3 for all HTTP certification crates |
Cargo.lock |
Lock file updates reflecting the dependency version changes and transitive dependency updates (e.g., cached, darling, base64) |
demos/vc_issuer/Cargo.lock |
Updated ic-certification version reference in demo lock file |
demos/test-app/Cargo.lock |
Updated ic-certification version and lock file format version |
src/internet_identity_interface/Cargo.toml |
Added ic-http-certification as a workspace dependency |
src/internet_identity_interface/src/http_gateway.rs |
Added TryFrom implementations for converting to ic_http_certification types, removed streaming_strategy field from HttpResponse struct |
src/internet_identity/internet_identity.did |
Removed streaming_strategy field from HttpResponse type definition |
src/internet_identity/src/http.rs |
Removed streaming_strategy: None from all HttpResponse instantiations |
src/internet_identity/tests/integration/http.rs |
Updated test to use try_into() conversion instead of manual field mapping |
src/archive/archive.did |
Removed streaming_strategy field from HttpResponse type definition |
src/archive/src/main.rs |
Removed streaming_strategy: None from all HttpResponse instantiations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 9 out of 12 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Motivation
The latest recommended version is 3.0.3, so we should start using it. Minor breaking changes required additional attention.
Changes
streaming_strategyfrom the Response API (which was an optional field that has never been used by II anyway)Tests
Existing tests should suffice.