feat: new summary for replacement proposals generated by the target topology tool
#1673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: we still will keep the old summary format with nakamoto for
dre subnet replaceanddre subnet heal. This PR only applies todre subnet force-replacewhich is meant to be used withtarget topologytooling.This PR tries to rethink some parts of how we do proposal summaries. The idea was to add as much data as possible (and link the full public parts) that the internal and external reviewers use to see if the proposal is correct.
To see the current proposal summary: proposal 137801
Example below:
Replace nodes in subnet vcpt7
Motivation:
Target topology entry
Target topology used was established in proposal 137147
Subnet id:
vcpt7-niq42-6snup-7kcgy-cndz6-srq6n-h6vwi-oswri-a3guc-v5ssd-5qeDetails
Nodes removed:
6ucn7-aiavt-uucq2-cvnjf-nwmr5-vetsg-q73h7-uzqjt-klm5x-e7qxu-mqe[health: healthy]csrkp-dimpe-7dybx-jmzjj-tjcjf-t57c4-tf4cq-cjeix-6tyah-qkyre-zae[health: healthy]Nodes added:
6hkcx-vz4jv-4n33r-ywdvs-sefaa-tb2on-rac6s-4csut-iyahu-zmct2-5qe[health: healthy]r7few-pljgn-iynmr-iprtj-p66dg-qpc5m-2tx4m-245oc-6dzgk-pu2wy-dae[health: healthy]