Skip to content

Add development Docker image and release 6.1.1 - #71

Merged
dfeen87 merged 1 commit into
mainfrom
codex/enhance-dockerfile-for-development
Sep 28, 2026
Merged

dfeen87 merged 1 commit into
mainfrom
codex/enhance-dockerfile-for-development

Conversation

@dfeen87

@dfeen87 dfeen87 commented Sep 28, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Provide a pinned, development-friendly Docker image that runs project Make targets in a mounted workspace and avoids running as root.
  • Bump the project/package/runtime metadata for a new patch release to keep versioning consistent across build and docs.

Description

  • Add a pinned development Dockerfile based on python:3.11.14-slim-bookworm that installs build tools, creates a non-root developer user, exposes /repro as the workspace volume, and uses make as the ENTRYPOINT.
  • Bump project version strings from 6.1.0 to 6.1.1 in pyproject.toml, setup.py, cura_frame/__init__.py, CMakeLists.txt, and CITATION.cff.
  • Update README.md to reflect the 6.1.1 badge and add a short Docker Build section with the build/run example using docker build -t curaframe:6.1.1 . and docker run --rm -v "$PWD:/repro" curaframe:6.1.1 test.
  • Add a docs/CHANGELOG.md entry for 6.1.1 noting the version bump and the new development container.

Testing

  • Ran the full test suite with python -m pytest, all tests passed (191 passed).
  • Verified package/runtime metadata with the inline Python assertions (cura_frame.__version__ and pyproject.toml are 6.1.1), which succeeded.
  • Ran a CMake configuration check with cmake -S . -B /tmp/curaframe-cmake-build, which completed successfully.
  • Ran git diff --check to ensure there are no whitespace/index issues, which returned clean.

Codex Task

Copilot AI balanced review requested due to automatic review settings September 28, 2026 22:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 68bc0c2f0b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Dockerfile
WORKDIR /repro
VOLUME ["/repro"]

ENTRYPOINT ["make"]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the Makefile invoked by the container

When the documented command mounts this checkout at /repro and passes test, the entrypoint executes make test, but this commit contains no Makefile, makefile, or GNUmakefile anywhere in the tracked tree. Consequently, every documented container invocation fails immediately with No rule to make target 'test'; add the intended Make targets or invoke an existing project command instead.

Useful? React with 👍 / 👎.

@dfeen87
dfeen87 merged commit 39c4477 into main Sep 28, 2026
2 checks passed
@dfeen87
dfeen87 deleted the codex/enhance-dockerfile-for-development branch September 28, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants