Add development Docker image and release 6.1.1 - #71
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68bc0c2f0b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| WORKDIR /repro | ||
| VOLUME ["/repro"] | ||
|
|
||
| ENTRYPOINT ["make"] |
There was a problem hiding this comment.
Add the Makefile invoked by the container
When the documented command mounts this checkout at /repro and passes test, the entrypoint executes make test, but this commit contains no Makefile, makefile, or GNUmakefile anywhere in the tracked tree. Consequently, every documented container invocation fails immediately with No rule to make target 'test'; add the intended Make targets or invoke an existing project command instead.
Useful? React with 👍 / 👎.
Motivation
Description
Dockerfilebased onpython:3.11.14-slim-bookwormthat installs build tools, creates a non-rootdeveloperuser, exposes/reproas the workspace volume, and usesmakeas theENTRYPOINT.6.1.0to6.1.1inpyproject.toml,setup.py,cura_frame/__init__.py,CMakeLists.txt, andCITATION.cff.README.mdto reflect the6.1.1badge and add a shortDocker Buildsection with the build/run example usingdocker build -t curaframe:6.1.1 .anddocker run --rm -v "$PWD:/repro" curaframe:6.1.1 test.docs/CHANGELOG.mdentry for6.1.1noting the version bump and the new development container.Testing
python -m pytest, all tests passed (191 passed).cura_frame.__version__andpyproject.tomlare6.1.1), which succeeded.cmake -S . -B /tmp/curaframe-cmake-build, which completed successfully.git diff --checkto ensure there are no whitespace/index issues, which returned clean.Codex Task