Add AQL pagination and dynamic include fields to avoid query timeouts#178
Open
christianwaldmann wants to merge 4 commits intodevopshq:masterfrom
Open
Add AQL pagination and dynamic include fields to avoid query timeouts#178christianwaldmann wants to merge 4 commits intodevopshq:masterfrom
christianwaldmann wants to merge 4 commits intodevopshq:masterfrom
Conversation
9524bf6 to
1df41f1
Compare
Contributor
Author
|
hi @allburov, can you have a look at this PR please and include it in a new release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
AQL queries can timeout out on large repositories. Two causes:
propertyandstattriggers unnecessary SQL joins even when the active rules don't need those fields, inflating every queryWhat does this PR do?
page_sizeparameter to fetch artifacts in pages instead of a single request. When not set, behavior is unchangedaql_add_include()hook so each rule declares only the AQL fields it actually needs, replacing the hardcoded.include("*", "property", "stat")on every queryUsage