compiler: Patch halo exchange placement at stree construction time - #3013
Open
FabioLuporini wants to merge 3 commits into
Open
compiler: Patch halo exchange placement at stree construction time#3013FabioLuporini wants to merge 3 commits into
FabioLuporini wants to merge 3 commits into
Conversation
mloubout
approved these changes
Aug 31, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3013 +/- ##
==========================================
- Coverage 83.68% 83.63% -0.06%
==========================================
Files 257 257
Lines 54711 54712 +1
Branches 4686 4688 +2
==========================================
- Hits 45785 45758 -27
- Misses 8115 8138 +23
- Partials 811 816 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mloubout
approved these changes
Sep 2, 2026
EdCaunt
reviewed
Sep 2, 2026
| if not all(c1.guards.get(d) == c.guards.get(d) for d in diff): | ||
| continue | ||
|
|
||
| # There must be at least one distributed Dimension |
Contributor
There was a problem hiding this comment.
Move this to immediately after dist_aindices = c1.halo_scheme.distributed_aindices to short circuit quicker
| assert len(trees[0]) == len(trees[1]) | ||
| assert all(i is j for i, j in zip(trees[0][:4], trees[1][:4], strict=True)) | ||
| assert trees[0][4] is not trees[1][4] | ||
| assert len(trees) == 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests in PRO