Open
Conversation
ivictbor
requested changes
Dec 9, 2025
| try { row[col.name] = JSON.parse(val); } | ||
| catch (e) { row[col.name] = val.split(',').map(s => s.trim()); } | ||
| } else { | ||
| row[col.name] = val.split(',').map(s => s.trim()); |
Contributor
There was a problem hiding this comment.
lets fix DRY on this line
row[col.name] = val.split(',').map(s => s.trim());
Instead we can use boolean like
let useCommaParsing = false;
and set it to true
index.ts
Outdated
| } | ||
| } | ||
| } else if (typeof val === 'number') { | ||
| row[col.name] = [val.toString()]; |
Contributor
There was a problem hiding this comment.
are u sure this is possible? if you will try to add console.log, can you make it executing and show screenshot here.
Contributor
There was a problem hiding this comment.
lets research why wand whether it is needed
ivictbor
requested changes
Dec 10, 2025
index.ts
Outdated
| } | ||
| } | ||
| } else if (typeof val === 'number') { | ||
| row[col.name] = [val.toString()]; |
Contributor
There was a problem hiding this comment.
lets research why wand whether it is needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.