Remove automatic Z stream version bumping in release branch#1584
Remove automatic Z stream version bumping in release branch#1584
Conversation
Signed-off-by: David Kwon <dakwon@redhat.com>
|
@dkwon17: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkwon17, rohanKanojia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
Fixes issue where whenever we did the DWO upstream release, there would be an unnecessary "chore: release: bump ..." (example) commit that would bump the deployment manifest image tags to use a bumped Z-stream, which is a non-existing image.
In the example provided above, v0.39.0 tags are being bumped to v0.39.1, even though v0.39.1 does not exist (v0.39.0 exists).
It's why I've needed to create a new commit to revert the change for the manifests to be usable: 43400de
What issues does this PR fix or reference?
n/a
Is it tested? How?
This change is not straight forward to test unfortunately. However, the change should be safe because we are simply preventing an image tag to be updated to a tag that does not exist.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che