Repository navigation
MODEM-PLAN, RADIOS-CAMERA-PLAN: find partitions by PARTNAME in M0 - #519
Merged
Merged
Conversation
The Arch root on the phone has no /dev/disk/by-partlabel, so the M0 commands that read the radio partitions through it fail there: M0.1's checksum loop (both plans), M0.5's blockdev --getro check and 1.6's name-to-device listing. derekross#490 fixed the same lookup in FINGERPRINT-PLAN, and the maintainer asked for these two plans to get the same treatment. Each command now finds its partition the way FB1 and F19.0 do, by PARTNAME in /sys/class/block/*/uevent, and 1.6 lists those PARTNAME lines in place of the by-partlabel symlinks. 1.6's "take a fresh backup" note now points at tools/nv-backup, which finds the partitions the same way. No step does anything else differently: the same partitions are read, nothing is mounted or written. MODEM-PLAN's M0 result note (2026-10-12) records what was run that day and is left as it was. Checked: the changed shell snippets parse (bash -n, sh -n), the lookup picks sda5 for efs over efs_backup on a fake sysfs, tools/pr-check origin/main and tests/all. Docs only; no phone was used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6 of 9 tasks
Owner
|
Thanks, Victor, this is exactly the follow-up I asked for in #490. I checked the lookup: it's the same line FB1 and F19.0 already use, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Follow-up to #490, as invited there: the Arch root on the phone has no
/dev/disk/by-partlabel, so the M0 commands in device/cheetah/MODEM-PLAN.md(M0.1, M0.5) and device/cheetah/RADIOS-CAMERA-PLAN.md (1.6 M0.1) that found the
radio partitions through it don't work there. Each now finds its partition by
PARTNAMEin/sys/class/block/*/uevent, with the same line FB1, F19.0 andMODEM-PLAN M3.4.2 use. 1.6 lists the
PARTNAMElines in place of theby-partlabel symlinks, and its "take a fresh backup" note now points at
tools/nv-backupinstead of a hand-written dd. No step does anything elsedifferently: the same partitions are read, and nothing is mounted or written.
Left as they were: MODEM-PLAN's M0 result note (2026-10-12), which records what
was run that day, and the comparison against the 2026-10-11 backup in both M0.1
steps.
tools/nv-backup --checkcould replace the M0.1 loop, but it adds checksthe step doesn't make today, so that's left for the same follow-up as FB1.
Device and build
uname -r): n/aChecks (no phone needed)
tools/pr-check origin/mainpassestests/allpassestests/packagespasses (or the packages I touched: none)versionbumped, and the new version is in the commit subject (no package changed)Co-Authored-By:orAssisted-by:trailer, never aSigned-off-by:On the phone
bash -n/sh -n, and the lookup against a fake sysfs.userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)🤖 Generated with Claude Code