Repository navigation
omamobile-omarchy 0.1.36: select 4.0.6 and 4.5 patch families - #471
marselnenaj wants to merge 3 commits into
Conversation
|
Thank you, @marselnenaj, this is a big piece of work, and the series port is very good. I checked it against the published Some context first: since 6 November our repository carries Omarchy's own 4.0.6 packages ( What I'd merge first (no phone test needed while phones are on 4.0.6, since nothing changes for them): the two series families and their selection, plus the migration holds from #469. Before that:
What needs another approach: the update-flow part.
For the record, here's what still stands between phones and 4.5 outside this PR. I'll track these on #434:
When those are done I'll move the pin to 4.5.0-3 rather than drop it, since the series selection accepts exact versions. Thanks again; the port itself is most of the work, and it's in good shape. |
500585f to
19fb6b1
Compare
|
Thank you, @marselnenaj. This is the split I hoped for. The update-flow pieces are all gone and Two things before I merge:
Smaller ones, if you're in there anyway:
Merge order: #469 first, then this rebased onto it, which drops the shared commit. I'll set the versions (0.1.35 and 0.1.36, since #478 took 0.1.34 earlier today) and write the squash message. No phone test is needed while phones stay on 4.0.6. I'll check the patch status on my 7 Pro after installing it, before it's published. |
19fb6b1 to
f0973e2
Compare
The case derekross#420's review left open: Hyprland sends a touch to the window under it whatever the screen's state, so on a dark unlocked phone a tap, or a double tap, landed in an app no one could see. omamobile-doubletap now looks at the screen four times a second and, when it goes dark while unlocked (an idle blank, the panel powered off by hand), runs omamobile-keys dark-unlocked, which locks behind the dark panel; the lock's surface then takes the touches. Only where the screen's state can be told (a DSI connector). The proximity claim's release moves into the same one-second wait. README: the dark-unlocked lock, that it works while the phone is awake (a double tap can't wake it from sleep), and that it times a double tap from lift to touch while the lock times touch to touch. omamobile-omarchy 0.1.37, omamobile-shell 0.2.103 (0.1.36 and 0.2.102 are claimed by derekross#471 and derekross#482). I used AI help (Claude) to work on this.
|
Thank you, @marselnenaj. Everything from my last two comments is in. The docs in all three places say where a fix goes now, the private lock hook is gone from One thing before I merge, and it's in the 4.5 patch headers. Eight of them (0015, 0016, 0017, 0018, 0019, 0022, 0023 and 0025) have replaced the original header, which says what the patch does and why, with a few lines whose spaces have gone missing, for example in 0023: The same thing shows in the 4.5 notes of 0017, 0020, 0021, 0024 and 0026 ("Omarchy4.5:"). These headers are the series' documentation, and the text we send upstream, so could you keep each original header and add a short, normally spaced "Omarchy 4.5:" paragraph on what the port changed, as you did well in 0001 and 0012? Please also drop "for private pixel.lock too" from 0023. If the two notification files 0023 brings back ( Two notes on my side, so you know what happens after the merge. The 4.5 family will start running on phones that already took Omarchy 4.5 before we pinned it, so I'll arrange a first run on one of those before it's published. And #420 adds a lock patch to I'll write the squash message myself, keeping your Codex co-author line. Thanks again; this is a careful piece of work. |
Keep the 4.0.6 series byte-identical while porting runtime contexts to 4.5.0. Select only supported source families and include mobile migration holds. Preserve the repository pin and production updater behavior. Do not ship the new updater gate, transaction shim or approval records. Keep the merged PR431 in the legacy archive byte for byte and leave its 4.5 port to jkjoplin. Preserve upstream copyright and MIT notices; remove false fixture-extension attribution. Run the full adapter suite against the signed 4.5.0-3 package, including fuzz-zero apply/reverse, idempotence, source selection, notification functions, 16 QML parses and native lock fixtures. No device update or physical smoke result is claimed. Co-Authored-By: Codex <codex@openai.com>
Document the version-selected patch families so fixes for current 4.0.6 phones reach the legacy family. Remove the external private-lock fixture hook; the suite uses only packaged lock sources and repository fixtures. Credit the mobile fixture additions to their confirmed human author while retaining Omarchy's original notice. Choose the sleep patch from the actual package version, keep Node and QML test tools optional, and format the new fixtures for maintenance. Make forget-by-key idempotent for valid missing keys and assert a repeated delete leaves state unchanged; malformed keys still fail. Run full adapter suites against the hash-pinned 4.0.6-1 and signed 4.5.0-3 packages, plus four inert family-selection and negative-control cases. Both suites pass. No external lock assets, phone actions or authentication policy changes are involved. Co-Authored-By: Codex <codex@openai.com>
Restore the original explanatory headers and retain their notices. Describe 4.5-specific changes in normally spaced paragraphs so the series remains useful documentation when fixes are maintained or sent upstream. Remove the private-lock wording from 0023. The restored NotificationLogic and NotificationCard APIs are used by the project mobile glance itself. Every functional patch payload and the entire legacy family remain identical. Header checks and the full actual-package 4.5 adapter suite pass. Co-Authored-By: Codex <codex@openai.com>
f0973e2 to
66b9c17
Compare
|
Updated in 66b9c17 and rebased onto current main. Restored the original explanatory headers, preserving their notices, and added short, normally spaced Both restored notification files are used by the project's own mobile glance: All functional patch payloads and the entire legacy family remain byte-identical to the previous PR head. The rebase preserves main's new remote-testing documentation alongside the patch-family guidance. Header invariance checks, #420 is still open, so no 0029 move was needed. If it lands first, its family placement will need to be handled when rebasing, as you described. Human authorship and the Codex co-author trailers are retained. |
|
Thank you, @marselnenaj. The headers read well now. Each of the eight has its original explanation back, word for word, with a short "Omarchy 4.5:" paragraph under it, and the private-lock wording is gone. Thanks also for the answer about This time I also ran the package's A few small things. I can fix them at merge if you'd rather not push again:
Before I can merge, one run on a phone. The development channel is published from main every morning, so once this merges, a phone that is already on Omarchy 4.5.0-3 gets the 4.5 family at its next update. That has never run on a phone. Could you do that run on your phone, if it's on 4.5.0-3, with this head's package installed and no private changes to Omarchy's files? If there are some, list them. The tool refuses to patch over a changed file, and that's worth knowing too. Then please post:
If you can't, I'll ask someone with a 4.5 phone, or do it myself when I'm back. On my 7 Pro, which stays on 4.0.6, I'll check the patch status after installing it. On #420: I tried its 0029 inside your 4.5 family on the real package, and it applies cleanly there too. So the order doesn't break anything at apply time. Whichever lands second still moves 0029 into I'll write the squash message myself and keep your Codex co-author line. Thanks again for the patience on this one. |
Select the mobile patch family from the installed Omarchy version: current 4.0.6 phones use
legacy-4.0.6/, while 4.5 usespatches/. AGENTS, README and RELEASES explain that fixes for current phones belong in the legacy family, and also in the 4.5 family when applicable.All 28 legacy patches retain their original bytes and notices, including jkjoplin's merged #431. Its 4.5 port remains omitted. Omarchy's original copyright and MIT terms are preserved, and the mobile fixture additions are credited to Marsel Nenaj.
The migration holds are already on main through #486; this branch is rebased after that merge and contains no shared #469 commit. The #478 updater, #486 holds and repository package pin remain unchanged.
Tests use only packaged lock sources and repository fixtures. The external private-lock override was local rendering scaffolding, not a missing packaged PIN fix, and is removed. Sleep-lock tests select their patch family from the actual archive version instead of a flat path or a build-machine symlink. Node and QML tools remain optional, with explicit skips when unavailable; new fixtures are formatted for maintenance.
For notification dismissal, a syntactically valid key that is already absent returns
okwithout mutating state. This makes a repeated swipe/delete idempotent and avoids a false error for an already-gone row. Malformed keys still returnnone.Validation:
Version 0.1.36 follows the maintainer's allocation. Phones remain pinned to 4.0.6 pending the separate runtime qualification tracked in #434.