Fix cook recipe modal container's local state to update after an edit - #4
Open
Shaderpixel wants to merge 2 commits into
Open
Fix cook recipe modal container's local state to update after an edit#4Shaderpixel wants to merge 2 commits into
Shaderpixel wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: A recipe's ingredients or instructions in the cook recipe modal do not reflect new edits when viewing it after saving edits. It only updates the cook recipe modal's local state after opening and closing it and the new changes will appear.
Fix: Use the getDerivedStateFromProps lifecycle method to do a simple array toString string comparison of props with local state values.