fix(existing-rule): aria-busy now shows an error message for a use with unallowed children

[chutchins25]

Updated existing rule for aria-required-children for cases where the aria-busy attribute is used. This now will show the user a specific error message regarding aria-busy with unallowed children instead of the one for used for other cases using unallowed children.

Replaces PR: 5011

Closes: #4626

[Copilot]

Pull request overview

Updates the aria-required-children check messaging so that when aria-busy is involved and unallowed children are present, the user receives a more specific failure message (per #4626 context).

Changes:

• Update the check evaluate logic to choose a different messageKey when aria-busy is present.
• Update/extend failure message strings to include the new aria-busy-fail message.
• Update the unit test expectation for the unallowed-children + aria-busy="true" case.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
lib/checks/aria/aria-required-children-evaluate.js	Adds conditional messageKey selection for unallowed-children failures when aria-busy is present.
lib/checks/aria/aria-required-children.json	Adds the new fail.aria-busy-fail message string.
locales/_template.json	Adds the new aria-busy-fail message to the locale template output.
test/checks/aria/required-children.js	Updates the test to expect the new failure messageKey in the aria-busy="true" + unallowed child scenario.

Comments suppressed due to low confidence (1)

lib/checks/aria/aria-required-children-evaluate.js:55

• The PR description/linked issue #4626 says aria-required-children “should never fail if aria-busy=true is set”, but the check still returns false when unallowed.length (even with aria-busy="true"), and the updated test asserts this failure. Please confirm the intended behavior; if the rule truly should not fail under aria-busy="true", the evaluate logic needs to bypass/soften the unallowed failure when busy, or the PR/issue linkage should be updated.

  if (unallowed.length) {
    this.relatedNodes(unallowed.map(({ vNode }) => vNode));
    const messageKey = virtualNode.hasAttr('aria-busy')
      ? 'aria-busy-fail'
      : 'unallowed';

    this.data({
      messageKey,
      values: unallowed
        .map(({ vNode, attr }) => getUnallowedSelector(vNode, attr))
        .filter((selector, index, array) => array.indexOf(selector) === index)
        .join(', ')
    });
    return false;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.