Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds release timestamps to Rust toolchain manifests so shared cooldown filtering applies correctly.
Changes:
- Parses manifest dates into
PackageRelease#released_at. - Adds release-date and cooldown filtering coverage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
package_details_fetcher.rb |
Creates dated package releases. |
package_details_fetcher_spec.rb |
Verifies retained release dates. |
latest_version_finder_spec.rb |
Tests nightly cooldown filtering. |
eitsupi
force-pushed
the
fix/rust-toolchain-cooldown-release-dates
branch
from
July 16, 2026 01:10
9754bde to
a8dbd08
Compare
eitsupi
force-pushed
the
fix/rust-toolchain-cooldown-release-dates
branch
from
July 16, 2026 01:16
a8dbd08 to
9188ed2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Rust toolchain releases currently have no
released_atvalue. The shared cooldown filter skips releases without that value, so configured cooldowns do not affect Rust toolchain updates. This was observed in apache/arrow-adbc#4530, where a one-day-old nightly was proposed despite a seven-day cooldown.Populate
PackageRelease#released_atfrom the date already present in eachmanifests.txtURL. This enables the existing shared cooldown implementation for dated channels and versioned toolchains.Anything you want to highlight for special attention from reviewers?
The manifest date is treated as UTC midnight. The updater already parses the same date from URLs when constructing dated channel versions.
How will you know you have accomplished your goal?
Added coverage that verifies manifest dates are retained for both nightly and versioned releases, and that a recent nightly is filtered by a seven-day cooldown while an older nightly remains eligible.
Checklist